chore(protocol-contracts): remove unstake recipient from ProtocolStaking
#1370
+61
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melanciani
previously approved these changes
Nov 20, 2025
jatZama
previously approved these changes
Nov 20, 2025
Co-authored-by: James Toussaint <[email protected]>
FrankLei-oz
reviewed
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the recipient for unstake requests from
ProtocolStaking(and the respective events). This mitigates an issue where any account can unstake 0 tokens on behalf of a given user. This is problematic if the cooldown period is decreased.The flow of requesting a redemption of 0 shares is modified in
OperatorStakingsuch that execution terminates early. Users must withdraw non-zero amount to affect any state.Docs are also updated to increase clarity.