-
Notifications
You must be signed in to change notification settings - Fork 182
feat(gpu): add support for a custom device selection on multi-gpu mode #2245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ba3139
to
46e4f39
Compare
tmontaigu
reviewed
Apr 11, 2025
tmontaigu
reviewed
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The custom case in the CudaStreamPools is not able to handle all possible cases but for now it should be enough
dede9e5
to
78b8a44
Compare
tmontaigu
reviewed
May 9, 2025
78b8a44
to
90b119c
Compare
agnesLeroy
reviewed
May 12, 2025
ed455f5
to
1d9a3d6
Compare
agnesLeroy
reviewed
May 12, 2025
1d9a3d6
to
ee482c5
Compare
agnesLeroy
approved these changes
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @pdroalves, looks good to me!
ee482c5
to
b400b2a
Compare
b400b2a
to
c8203eb
Compare
… a custom selection of GPUs
267b986
to
ba3d3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/960
PR content/description
Check-list: