Skip to content

feat(gpu): add support for a custom device selection on multi-gpu mode #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

pdroalves
Copy link
Contributor

@pdroalves pdroalves commented Apr 7, 2025

closes: https://github.com/zama-ai/tfhe-rs-internal/issues/960

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Apr 7, 2025
@pdroalves pdroalves force-pushed the pa/feat/arbitrary_multi_gpus branch 3 times, most recently from 3ba3139 to 46e4f39 Compare April 9, 2025 17:08
Copy link
Contributor

@tmontaigu tmontaigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom case in the CudaStreamPools is not able to handle all possible cases but for now it should be enough

@pdroalves pdroalves force-pushed the pa/feat/arbitrary_multi_gpus branch 2 times, most recently from dede9e5 to 78b8a44 Compare May 8, 2025 15:16
@zama-bot zama-bot removed the approved label May 8, 2025
@pdroalves pdroalves force-pushed the pa/feat/arbitrary_multi_gpus branch from 78b8a44 to 90b119c Compare May 9, 2025 12:47
@pdroalves pdroalves marked this pull request as ready for review May 9, 2025 12:54
@pdroalves pdroalves requested review from tmontaigu and agnesLeroy May 9, 2025 12:54
@pdroalves pdroalves force-pushed the pa/feat/arbitrary_multi_gpus branch 4 times, most recently from ed455f5 to 1d9a3d6 Compare May 12, 2025 14:06
@pdroalves pdroalves force-pushed the pa/feat/arbitrary_multi_gpus branch from 1d9a3d6 to ee482c5 Compare May 12, 2025 14:14
Copy link
Contributor

@agnesLeroy agnesLeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @pdroalves, looks good to me!

@pdroalves pdroalves force-pushed the pa/feat/arbitrary_multi_gpus branch from ee482c5 to b400b2a Compare May 12, 2025 15:43
@zama-bot zama-bot removed the approved label May 12, 2025
@agnesLeroy agnesLeroy force-pushed the pa/feat/arbitrary_multi_gpus branch from b400b2a to c8203eb Compare May 13, 2025 07:10
@pdroalves pdroalves force-pushed the pa/feat/arbitrary_multi_gpus branch from 267b986 to ba3d3cb Compare May 13, 2025 10:49
@agnesLeroy agnesLeroy merged commit 0280dbe into main May 14, 2025
55 of 57 checks passed
@agnesLeroy agnesLeroy deleted the pa/feat/arbitrary_multi_gpus branch May 14, 2025 07:24
@pdroalves pdroalves restored the pa/feat/arbitrary_multi_gpus branch May 15, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants