refactor(gpu): match_value to backend #2989
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enzodimaria
force-pushed
the
edm/vector_find_to_backend
branch
2 times, most recently
from
18d8f80 to
3581826
Compare
enzodimaria
force-pushed
the
edm/vector_find_to_backend
branch
from
3581826 to
8f80d4f
Compare
enzodimaria
force-pushed
the
edm/vector_find_to_backend
branch
from
8f80d4f to
f1e19de
Compare
enzodimaria
force-pushed
the
edm/vector_find_to_backend
branch
from
f1e19de to
2a72a73
Compare
enzodimaria
force-pushed
the
edm/vector_find_to_backend
branch
from
2a72a73 to
6609335
Compare
agnesLeroy
reviewed
Nov 10, 2025
Contributor
agnesLeroy
left a comment
agnesLeroy
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR @enzodimaria! You'll see I have some comments: one of them is that it'll be better performance wise to operate on possible values in parallel. You could:
- take into account other review comments
- do the change for compute_equality_selectors in a separate commit and ask for my review again, so we go step by step with it.
|
|
||
| uint32_t num_chunks = (num_input_ciphertexts + chunk_size - 1) / chunk_size; | ||
|
|
||
| for (uint32_t chunk_idx = 0; chunk_idx < num_chunks - 1; chunk_idx++) { |
Contributor
There was a problem hiding this comment.
These two loops can also be executed in parallel (see tfhe/src/integer/server_key/radix_parallel/vector_find.rs:1285). Would be good to use different streams to do this.
enzodimaria
force-pushed
the
edm/vector_find_to_backend
branch
from
6609335 to
aee97f8
Compare
enzodimaria
force-pushed
the
edm/vector_find_to_backend
branch
from
aee97f8 to
793e5c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: