Skip to content

use proxy to download server resourece pack on any server #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

use proxy to download server resourece pack on any server #309

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7bf484
use proxy to download server resourece pack on any server from any no…
zardoy Dec 20, 2024
1ee52f7
Merge branch 'next' into pr/zardoy/309
zardoy Mar 14, 2025
e51e0e9
so damn clean cursor impl
zardoy Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/resourcePack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,11 +389,26 @@ const downloadAndUseResourcePack = async (url: string, progressReporter: Progres
progressReporter.beginStage('download-resource-pack', 'Downloading server resource pack')
console.log('Downloading server resource pack', url)
console.time('downloadServerResourcePack')
const response = await fetch(url).catch((err) => {

// Try direct URL first
let response = await fetch(url).catch((err) => {
console.log(`Ensure server on ${url} support CORS which is not required for regular client, but is required for the web client`)
console.error(err)
progressReporter.error('Failed to download resource pack: ' + err.message)
return null
})

// If direct URL fails, try proxy URL
if (!response) {
const urlWithoutProtocol = url.replace(/^https?:\/\//, '')
const proxyUrl = `https://mcraft-proxy.vercel.app/0/${urlWithoutProtocol}`
Copy link

@Phoenix616 Phoenix616 Mar 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make more sense to use the proxy that is already used for the packets for the resource pack too? That way this centralised failure point could be prevented. Also you could prevent abuse of the proxy server as right now one can query other arbitrary files through that url (which might expose you to some legal issues too). If the webclient proxy would handle the pack proxying as well then it could cache which server resource packs actually got sent from the server and only allow proxying those.

console.log('Trying fallback proxy URL:', proxyUrl)
response = await fetch(proxyUrl).catch((err) => {
console.error('Proxy fetch also failed:', err)
progressReporter.error('Failed to download resource pack: ' + err.message)
return null
})
}

console.timeEnd('downloadServerResourcePack')
if (!response) return

Expand Down
Loading