Skip to content

fix: Effects and Game Indicators overlay toggles didn't work #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

fix: Effects and Game Indicators overlay toggles didn't work #397

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56ddf54
fix: Effects and Game Indicators overlay toggles didn't work
Phoenix616 Jul 17, 2025
d14b239
Better fix for disabling of the effects and game indicators
Phoenix616 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/react/IndicatorEffectsProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { Effect } from 'mineflayer'
import { inGameError } from '../utils'
import { fsState } from '../loadSave'
import { gameAdditionalState, miscUiState } from '../globalState'
import { options } from '../optionsStorage'
import IndicatorEffects, { EffectType, defaultIndicatorsState } from './IndicatorEffects'
import { images } from './effectsImages'

Expand Down Expand Up @@ -67,7 +66,6 @@ export default ({ displayEffects = true, displayIndicators = true }: { displayEf
const { mesherWork } = useSnapshot(appViewer.rendererState).world

const { hasErrors } = useSnapshot(miscUiState)
const { disabledUiParts } = useSnapshot(options)
const { isReadonly, openReadOperations, openWriteOperations } = useSnapshot(fsState)
const { noConnection, poorConnection } = useSnapshot(gameAdditionalState)
const allIndicators: typeof defaultIndicatorsState = {
Expand Down Expand Up @@ -120,8 +118,8 @@ export default ({ displayEffects = true, displayIndicators = true }: { displayEf
}, [])

return <IndicatorEffects
indicators={allIndicators}
effects={effects}
indicators={displayIndicators ? allIndicators : defaultIndicatorsState}
effects={displayEffects ? effects : []}
displayIndicators
displayEffects
/>
Expand Down
Loading