Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an ImportError for HDFVirtualBackend without h5py installed. #481

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

sharkinsspatial
Copy link
Collaborator

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.66%. Comparing base (fd3a916) to head (0e89f2d).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
virtualizarr/readers/hdf/hdf.py 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #481      +/-   ##
===========================================
- Coverage    88.70%   88.66%   -0.05%     
===========================================
  Files           28       28              
  Lines         1753     1755       +2     
===========================================
+ Hits          1555     1556       +1     
- Misses         198      199       +1     
Files with missing lines Coverage Δ
virtualizarr/readers/hdf/hdf.py 94.84% <50.00%> (-0.47%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxrjones maxrjones changed the base branch from main to develop March 7, 2025 21:18
@maxrjones maxrjones merged commit 24a886c into develop Mar 7, 2025
11 of 12 checks passed
@maxrjones maxrjones deleted the fix/soft_import branch March 7, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message when following usage guide without h5py installed
3 participants