-
Notifications
You must be signed in to change notification settings - Fork 49
feat: nested group in ManifestStore + HDFParser
#790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Sorry I think I should have linked to #84. What we want is to add
NetCDF4 is HDF5 in a trenchcoat 🙂 NetCDF3 cannot handle groups. TIFF can. FITS IDK. |
Good point, but I don't see any tiff tests at the moment. I'd be happy to add them if you want. But then I would need to edit the Tiff parser so perhaps this PR should be limited to the store + hdf5
Hmm, it seems adding a check for subgroups caused tests to fail. It looks like opening a group with a subgroup actually does work but just creates a dataset object at the root group if present, ignoring the other subkeys. Judging by the tests, this is intentional. So I can remove the check then that I added here. I guess the vibes well with having a new API in EDIT: done! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
+ Coverage 87.75% 87.78% +0.03%
==========================================
Files 35 35
Lines 1886 1891 +5
==========================================
+ Hits 1655 1660 +5
Misses 231 231
🚀 New features to boost your workflow:
|
ManifestStore + HDFParser
Some potential TODOs:
h5objects from currently parsed file formats that fit the nested paradigm and would otherwise have not workedAlong the lines of 1., maybe bring inI think this raises separate issues becauseanndataas an optional dep to test the behavior of this more deeplyanndatahas semantics around object dtype that would need to be handled by a parser, I thinkopen_virtual_datasetseems to return anxarray.Datasetbut I think in the case where things are nested, it should return aDataTreemaybe? or error out?construct_virtual_datasetand thusManifestStore.to_virtual_datasetsuffer the same issueCan the non-hdf5 formats handle nested structures, like
netCDForfits?Closes
hdfparser limited to level-0h5py.Dataset#664Tests added
Tests passing
Full type hint coverage
Changes are documented in
docs/releases.rstNew functions/methods are listed in
api.rstNew functionality has documentation