Add numpy 2.0 compatibility#535
Merged
normanrz merged 8 commits intozarr-developers:mainfrom Jun 20, 2024
dstansby:numpy-2
Merged
Add numpy 2.0 compatibility#535normanrz merged 8 commits intozarr-developers:mainfrom dstansby:numpy-2
normanrz merged 8 commits intozarr-developers:mainfrom
dstansby:numpy-2
Conversation
Closed
normanrz
approved these changes
Jun 19, 2024
Member
normanrz
left a comment
There was a problem hiding this comment.
I think this it a good solution. I will merge tomorrow if there are no objections.
We should track numpy 2.0 support in zfpy, though.
Contributor
Author
|
I updated this so the Python 3.10 tests use |
DimitriPapadopoulos
pushed a commit
to DimitriPapadopoulos/numcodecs
that referenced
this pull request
Aug 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 59 59
Lines 2318 2318
=======================================
Hits 2316 2316
Misses 2 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #521.
Currently the solution is to just test without zfpy support, which is easy to implement. In an ideaL world I guess we want to run at least one test with zfpy and
numpy<2? I won't have time to implement that in the next few days, so someone else feel free to take over and do that if desirable.