Upgraded pcodec to 0.2 and used new ModeSpec configuration#544
Merged
rabernat merged 5 commits intozarr-developers:mainfrom Jul 9, 2024
Merged
Upgraded pcodec to 0.2 and used new ModeSpec configuration#544rabernat merged 5 commits intozarr-developers:mainfrom
rabernat merged 5 commits intozarr-developers:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 99.91% 99.82% -0.09%
==========================================
Files 59 59
Lines 2319 2339 +20
==========================================
+ Hits 2317 2335 +18
- Misses 2 4 +2
|
Contributor
Author
|
It seems the lines the coverage report is complaining about are deliberately unreachable (with correct mypy typing) |
Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>
Contributor
Author
Contributor
Author
Contributor
DimitriPapadopoulos
pushed a commit
to DimitriPapadopoulos/numcodecs
that referenced
this pull request
Aug 10, 2024
…lopers#544) * Upgraded pcodec to 0.2 and used new ModeSpec configuration * test coverage fix Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com> * actually test the line since it seems there's no way around it * fix pre-commit --------- Co-authored-by: Norman Rzepka <code@normanrz.com> Co-authored-by: Ryan Abernathey <ryan.abernathey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Upgraded Pcodec to 0.2. The main API change is replacement of individual mode specs with a single spec for all modes.