Skip to content

(fix): ensure no typesize in the Blosc config #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Apr 13, 2025

Addressing #713 (comment), I think it should be really this easy, but not so familiar with this area of things.

cc @jbms @dstansby

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (3438e16) to head (b93952a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          63       63           
  Lines        2736     2740    +4     
=======================================
+ Hits         2735     2739    +4     
  Misses          1        1           
Files with missing lines Coverage Δ
numcodecs/tests/test_blosc.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilan-gold
Copy link
Contributor Author

@jbms or @dstansby ping!

@d-v-b
Copy link
Contributor

d-v-b commented Apr 23, 2025

this looks good to me, thanks for reverting this @ilan-gold.

@d-v-b
Copy link
Contributor

d-v-b commented Apr 24, 2025

I'm going to merge this soon unless anyone objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants