Skip to content

Conversation

@SO9010
Copy link
Contributor

@SO9010 SO9010 commented Nov 3, 2025

Closes #7335

This is an attempt at creating the feature of disabling syntax highlighting. I tried my best, if there are parts which are wrong, or my approach to this is completely wrong, please do let me know, this one was a lot more challenging than my last PR. All feedback is super, super valuable to me, so I thank you in advance!
Release Notes:

  • Added an option to stop syntax highlighting.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 3, 2025
@maxdeviant maxdeviant changed the title Language: Add option to disable syntax highlighting language: Add option to disable syntax highlighting Nov 3, 2025
@SO9010
Copy link
Contributor Author

SO9010 commented Nov 5, 2025

Sorry for all the mistakes :,) it should be all good now.

@SO9010
Copy link
Contributor Author

SO9010 commented Nov 5, 2025

Im not sure why its not parsing the test...

Copy link
Contributor

@tie tie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It’d be nice to have an action to toggle syntax highlighting (e.g. like Editor::ToggleSoftWrap, Editor::ToggleIndentGuides, etc).
  • Code in hover popover still contains highlighted text.
    Image

@SO9010
Copy link
Contributor Author

SO9010 commented Nov 8, 2025

Hello, thank you so much for the review! I'm sorry I have so many small mistakes, my next pr will be better!!! Sorry for wasting your time... This doesn't usually happen! 😞 I will work on this asap.

@SO9010 SO9010 marked this pull request as draft November 8, 2025 15:48
@SO9010
Copy link
Contributor Author

SO9010 commented Nov 8, 2025

Alright, just have to figure out how to create an action toggle, and then to remove the highlighting in the pop-over - I really appreciate the help. I have put this as a draft PR for now.

Edit: Update! I have found the location of the code to remove the syntax highlighting from the pop-over. I will be able to work on this soon!

@SO9010
Copy link
Contributor Author

SO9010 commented Nov 11, 2025

Hmm, I think I am taking the complete wrong approach, sorry about this!

@SO9010 SO9010 marked this pull request as ready for review November 16, 2025 17:21
@SO9010 SO9010 requested review from elmarco and tie November 19, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable syntax highlighting

3 participants