ci: Correct workflow name for run_unit_evals #42047
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @Huggyturd on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @Huggyturd on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
maxdeviant
changed the title
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @Huggyturd on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
The run_unit_evals.yml workflow was incorrectly named 'run_agent_evals' due to both workflows being generated from the same module. This caused duplicate workflow names in GitHub Actions. Changes: - Updated run_agent_evals.rs to explicitly set the workflow name for run_unit_evals to 'run_unit_evals' - Regenerated workflows using 'cargo xtask workflows' - The workflow file now correctly identifies itself as 'run_unit_evals' This fixes potential CI/CD issues where GitHub Actions would be confused by duplicate workflow names.
clouraLabs
force-pushed
the
fix-workflow-name-run-unit-evals
branch
from
39513e2 to
44c00b7
Compare
|
We require contributors to sign our Contributor License Agreement, and we don't have @clouraLabs on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @clouraLabs on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
2 participants
Summary
This PR fixes a duplicate workflow name issue in GitHub Actions where the
run_unit_evals.ymlworkflow was incorrectly namedrun_agent_evals, causing potential confusion with the actualrun_agent_evals.ymlworkflow.Problem
The
.github/workflows/run_unit_evals.ymlfile had its workflow name set torun_agent_evalsinstead ofrun_unit_evals. This occurred because both therun_agent_evals()andrun_unit_evals()functions intooling/xtask/src/tasks/workflows/run_agent_evals.rswere using thenamed::workflow()helper, which automatically derives the workflow name from the module name. Since both functions are in the same module, they both inherited the namerun_agent_evals.Solution
tooling/xtask/src/tasks/workflows/run_agent_evals.rsto explicitly set the workflow name forrun_unit_evalsby usingWorkflow::default().name("run_unit_evals".to_string())instead ofnamed::workflow()cargo xtask workflowsrun_unit_evalsChanges
.github/workflows/run_unit_evals.yml: Updated workflow name fromrun_agent_evalstorun_unit_evalstooling/xtask/src/tasks/workflows/run_agent_evals.rs: Explicitly set workflow name to prevent future confusionTesting
.github/workflows/directoryThis ensures GitHub Actions can properly distinguish between the two workflows and prevents potential CI/CD issues.