tabular_data_preview: Extract table component from the preview pane - #63752
Open
HalavicH wants to merge 8 commits into
Open
Conversation
HalavicH
marked this pull request as ready for review
September 4, 2026 10:40
HalavicH
force-pushed
the
refactor/tabular-data-preview/extract-table-view-into-separate-component
branch
from
September 4, 2026 10:44
abbedd9 to
dd2ea57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
TabularDataPreviewPanedid rendering, focus, engine, and settings all in one component.Extracted the table-rendering half into
TableView(newtable_view.rs), so the pane now owns tab/item concerns and just embedsself.table: Entity<TableView>which allows the table to be reusable in other contexts (i.e. multiple tables per pane or rendering data from other sources like DB client).Testing
cargo check -p tabular_data_preview,./script/clippyclean.Self-Review Checklist:
Release Notes: