Skip to content

tabular_data_preview: Extract table component from the preview pane - #63752

Open
HalavicH wants to merge 8 commits into
zed-industries:mainfrom
HalavicH:refactor/tabular-data-preview/extract-table-view-into-separate-component
Open

tabular_data_preview: Extract table component from the preview pane#63752
HalavicH wants to merge 8 commits into
zed-industries:mainfrom
HalavicH:refactor/tabular-data-preview/extract-table-view-into-separate-component

Conversation

@HalavicH

@HalavicH HalavicH commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

TL;DR

TabularDataPreviewPane did rendering, focus, engine, and settings all in one component.

Extracted the table-rendering half into TableView (new table_view.rs), so the pane now owns tab/item concerns and just embeds self.table: Entity<TableView> which allows the table to be reusable in other contexts (i.e. multiple tables per pane or rendering data from other sources like DB client).

NOTE: No behavior changes. Only refactoring

Testing

  • cargo check -p tabular_data_preview, ./script/clippy clean.
  • Tested manually: no UI/UX/performance regressions

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • UI standards followed
  • Tests cover the new/changed behavior
  • Performance impact considered, acceptable

Release Notes:

  • N/A

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Sep 4, 2026
@zed-community-bot zed-community-bot Bot added the community champion Issues filed by our amazing community champions! 🫶 label Sep 4, 2026
@HalavicH HalavicH changed the title Refactor/tabular data preview/extract table view into separate component tabular_data_preview: Extract table component from the preview pane Sep 4, 2026
@HalavicH HalavicH changed the title tabular_data_preview: Extract table component from the preview pane Refactor/tabular data preview/extract table view into separate component Sep 4, 2026
@HalavicH HalavicH changed the title Refactor/tabular data preview/extract table view into separate component tabular_data_preview: Extract table component from the preview pane Sep 4, 2026
@HalavicH
HalavicH marked this pull request as ready for review September 4, 2026 10:40
@HalavicH
HalavicH force-pushed the refactor/tabular-data-preview/extract-table-view-into-separate-component branch from abbedd9 to dd2ea57 Compare September 4, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant