lib: Update agl and sead#164
Conversation
There was a problem hiding this comment.
There are regression in agl with Parameter and ParameterCurve stuff
These functions disappeared:
agl::utl::ParameterCurve<(unsigned int)4>::ParameterCurve(sead::SafeStringBase<char> const&, sead::SafeStringBase<char> const&, agl::utl::IParameterObj*)
agl::utl::Parameter<sead::FixedSafeString<256> >::Parameter(sead::FixedSafeString<256> const&, sead::SafeStringBase<char> const&, sead::SafeStringBase<char> const&, agl::utl::IParameterObj*)
agl::utl::Parameter<sead::FixedSafeString<64> >::Parameter(sead::FixedSafeString<64> const&, sead::SafeStringBase<char> const&, sead::SafeStringBase<char> const&, agl::utl::IParameterObj*)
agl::utl::Parameter<sead::FixedSafeString<32> >::~Parameter()
agl::utl::Parameter<sead::FixedSafeString<32> >::Parameter(sead::FixedSafeString<32> const&, sead::SafeStringBase<char> const&, sead::SafeStringBase<char> const&, agl::utl::IParameterObj*)
agl::utl::Parameter<float>::~Parameter()
agl::utl::Parameter<sead::FixedSafeString<64> >::~Parameter()
The disappeared dtors are all D1
|
This is true and expected. Those need to be actually used to generate the symbol. I removed a hack that forced all these symbols to be generated. See open-ead/agl#23 for more details |
|
Doesn't createByTypeName use it? |
|
createByTypeName uses the default ctor but ParameterBase also has ctors that take parameters and those need to be called explicitly to be generated. Not sure if dtors should be generated, I suppose they aren't since this doesn't destroy any of these objects but I would have to double check those. |
Is been a while since last update of these submodules
This change is