Skip to content

lib: Update agl and sead#164

Open
german77 wants to merge 2 commits intozeldaret:masterfrom
german77:submodule
Open

lib: Update agl and sead#164
german77 wants to merge 2 commits intozeldaret:masterfrom
german77:submodule

Conversation

@german77
Copy link
Copy Markdown

@german77 german77 commented Apr 24, 2026

Is been a while since last update of these submodules


This change is Reviewable

Copy link
Copy Markdown
Collaborator

@Pistonight Pistonight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are regression in agl with Parameter and ParameterCurve stuff

These functions disappeared:

agl::utl::ParameterCurve<(unsigned int)4>::ParameterCurve(sead::SafeStringBase<char> const&, sead::SafeStringBase<char> const&, agl::utl::IParameterObj*)

agl::utl::Parameter<sead::FixedSafeString<256> >::Parameter(sead::FixedSafeString<256> const&, sead::SafeStringBase<char> const&, sead::SafeStringBase<char> const&, agl::utl::IParameterObj*)

agl::utl::Parameter<sead::FixedSafeString<64> >::Parameter(sead::FixedSafeString<64> const&, sead::SafeStringBase<char> const&, sead::SafeStringBase<char> const&, agl::utl::IParameterObj*)

agl::utl::Parameter<sead::FixedSafeString<32> >::~Parameter()

agl::utl::Parameter<sead::FixedSafeString<32> >::Parameter(sead::FixedSafeString<32> const&, sead::SafeStringBase<char> const&, sead::SafeStringBase<char> const&, agl::utl::IParameterObj*)

agl::utl::Parameter<float>::~Parameter()

agl::utl::Parameter<sead::FixedSafeString<64> >::~Parameter()

The disappeared dtors are all D1

@german77
Copy link
Copy Markdown
Author

This is true and expected. Those need to be actually used to generate the symbol. I removed a hack that forced all these symbols to be generated. See open-ead/agl#23 for more details

@Pistonight
Copy link
Copy Markdown
Collaborator

Doesn't createByTypeName use it?
Either way the CSV has these symbols so something needs to be fixed before this can merge

@german77
Copy link
Copy Markdown
Author

createByTypeName uses the default ctor but ParameterBase also has ctors that take parameters and those need to be called explicitly to be generated. Not sure if dtors should be generated, I suppose they aren't since this doesn't destroy any of these objects but I would have to double check those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants