Skip to content

Add command component #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Add command component #97

merged 2 commits into from
Feb 12, 2025

Conversation

Cahllagerfeld
Copy link
Collaborator

@Cahllagerfeld Cahllagerfeld commented Feb 11, 2025

Component was added to Storybook

Copy link
Contributor

@kiprasmel kiprasmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misc but otherwise lgtm

return (
<Dialog {...props}>
<DialogContent className="overflow-hidden p-0">
<Command className="[&_[cmdk-group-heading]]:text-muted-foreground [&_[cmdk-group-heading]]:px-2 [&_[cmdk-group-heading]]:font-medium [&_[cmdk-group]:not([hidden])_~[cmdk-group]]:pt-0 [&_[cmdk-group]]:px-2 [&_[cmdk-input-wrapper]_svg]:h-5 [&_[cmdk-input-wrapper]_svg]:w-5 [&_[cmdk-input]]:h-12 [&_[cmdk-item]]:px-2 [&_[cmdk-item]]:py-3 [&_[cmdk-item]_svg]:h-5 [&_[cmdk-item]_svg]:w-5">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks v weird, is this the expected way to do styling?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it from shadcn, and adjusted it to our designsystem 😅

https://ui.shadcn.com/docs/components/command

@Cahllagerfeld Cahllagerfeld merged commit 279169d into main Feb 12, 2025
2 checks passed
@Cahllagerfeld Cahllagerfeld deleted the feat/add-command branch February 12, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants