-
Notifications
You must be signed in to change notification settings - Fork 501
Improve run template UX #3602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Improve run template UX #3602
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
6a07c5a
to
c961e47
Compare
b0a662e
to
393cac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just thought this was a bit confusing
Describe changes
This PR contains some UX improvements for run templates, mostly aimed towards the UX when running a template from the dashboard:
None
and default (=empty) values from the run config template. This makes the text editor when running a template from the UI much more useful as it only contains relevant information.None
values as not set and ignore them, which means there will be no way to "unset" a value when triggering a template. It is for example not possible to remove a failure hook source that was set for the run from which the template was created.Breaking changes:
step_config_overrides
attribute was added to a pydantic class which does not allow extra attributes. This means this change will be incompatible with different client and server versions.Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes