🗺Added support for multiple coordinate systems#1
Open
rmeertens wants to merge 1 commit intozenseact:mainfrom
Open
🗺Added support for multiple coordinate systems#1rmeertens wants to merge 1 commit intozenseact:mainfrom
rmeertens wants to merge 1 commit intozenseact:mainfrom
Conversation
alibeigi
reviewed
Mar 11, 2022
| @@ -1,4 +1,7 @@ | |||
| """Converts dynamic object annotations to KITTI format.""" | |||
| import os, sys | |||
| sys.path.append(os.path.join(os.path.dirname(__file__), "../")) | |||
| def _parse_args(): | ||
| parser = argparse.ArgumentParser(description="Convert annotations to KITTI format") | ||
| parser.add_argument("--dataset-dir", required=True, help="Root dataset directory") | ||
| parser.add_argument("--dataset-dir", required=True, help="Root dataset directory. Assumed to contain json files with label-coordinates in the zenseact lidar coordinate system") |
There was a problem hiding this comment.
Please keep the line width to 100 by adding a new line.
| parser.add_argument("--dataset-dir", required=True, help="Root dataset directory") | ||
| parser.add_argument("--dataset-dir", required=True, help="Root dataset directory. Assumed to contain json files with label-coordinates in the zenseact lidar coordinate system") | ||
| parser.add_argument("--target-dir", required=True, help="Output directory") | ||
| parser.add_argument("--target_coordinate_system", required=True, help="What coordinate system to convert files to") |
There was a problem hiding this comment.
Would be nice to add choices=['kitti_camera', 'zenseact_lidar']
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.