-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add module name #54
base: zephyr
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. There should be a single commit and no merge commits as part of normal PRs (so basically the second commit shouldn't be there).
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some of the PR description to the commit message for context. Also, the commit title should rather follow the structure <area touched>: <what is done>
so e.g. zephyr/module.yml: add module name
something like this? |
The module name is now explicitly set in module.yml, this ensures that building with e.g. cmake does not fail when the directory name is different (default name if unset is directory name).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
This MR adds the module name in zephyr/module.yml, as is stated in the official documentation: