rewrite history & replace readme #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi-font
requested review from
Vge0rge,
ceolin,
d3zd3z,
dleach02,
ithinuel,
valeriosetti and
wearyzen
Collaborator
|
This commit doesn't have a tag. Only one question otherwise it looks fine: since this is not a version bumping I assume the rule Another curiosity: in |
Collaborator
Author
Oh, how did I mess this up, the tag went into the first line of the commit message.
Oh right, actually yes I'd say it does, any history rewrite is good to reorder the commits.
Hmm no, I'll add this missing patch. Also I just realized that for some time TF-M has had two patches named 0005 and this was fixed very recently: TrustedFirmware-M/tf-m-tests@117e2cd#diff-8902de013ecae9b38f4a3556ca616668e675e6ea8b92e85886eedd72bcd53ed3 |
tomi-font
force-pushed
the
rewrite_history_add_patch_guidelines
branch
from
469dcbf to
d3f0498
Compare
Collaborator
Author
|
Comments addressed. |
valeriosetti
approved these changes
Oct 31, 2025
tomi-font
force-pushed
the
rewrite_history_add_patch_guidelines
branch
from
d3f0498 to
3f99e9a
Compare
tomi-font
changed the base branch from
zephyr_psa-arch-tests-v1.6
to
zephyr_psa-arch-tests_v1.6
…registers This ensures that GCC 14.3 performs the register accesses in the specified manner instead of reordering or combining them using strd/ldrd instructions. Signed-off-by: Keith Packard <[email protected]> (cherry picked from commit f0d43a6)
HMAC_DRBG random generator is slower than CTR_DRBG, and this will influence the time spending for test 16 RSA 2048. Placing test 16 at the beginning will be faster and mitigate this issue. Signed-off-by: Summer Qin <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0001-Place-crypto-test-16-at-the-beginning-of-the-test.patch Signed-off-by: Tomi Fontanilles <[email protected]>
Test 16 uses macro PSA_EXPORT_KEY_PAIR_MAX_SIZE which is related with PSA_WANT_KEY_TYPE_xxx_KEY_PAIR_BASIC defines in mbedtls 3.5. PSA_WANT_KEY_TYPE_xxx_KEY_PAIR_BASIC are defined in psa crypto config. Signed-off-by: Summer Qin <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0002-Crypto-Add-psa-crypto-config-link-for-crypto-tests.patch Signed-off-by: Tomi Fontanilles <[email protected]>
Signed-off-by: Kevin Peng <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0003-Build-Add-manifest-tool-dependencies.patch Signed-off-by: Tomi Fontanilles <[email protected]>
Signed-off-by: Gergely Korcsák <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0004-Add-msp4-target-config-for-Corstone-315-and-320.patch Signed-off-by: Tomi Fontanilles <[email protected]>
Change-Id: I50777e655dfecdac7e4cacecbff8459efa4d7a77 Signed-off-by: Gabor Abonyi <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0005-Add-rp2350-platform.patch Signed-off-by: Tomi Fontanilles <[email protected]>
With the existance of Corstone 300, 310, 315 and 320 the cs3x0 does not apply correctly. Corstone 315 and 320 uses different UART driver location. To do not create 4 different platforms, we regrouped them by FPGA names. Corstone 300 and 310 as mps3 and Corstone 315 and 320 as mps4. Signed-off-by: Gergely Korcsák <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0006-Rename-cs3x0-to-mps3.patch Signed-off-by: Tomi Fontanilles <[email protected]>
Armclang 6.21 reports missing-field-initializers warning for missing designated initializers. This will be fixed in armclang 6.22. Currently, use designated initializers as workaround. Signed-off-by: Summer Qin <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0007-Attest-Use-designated-initializers.patch Signed-off-by: Tomi Fontanilles <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0008-Fix-buffer-overflow-in-test_c061-63.c.patch Signed-off-by: Tomi Fontanilles <[email protected]>
Signed-off-by: Stephan Koch <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0009-Use-rsa_128_key_data-which-has-expected-format.patch Signed-off-by: Tomi Fontanilles <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0010-Update-Musca-S1-B1-platform-configuration.patch Signed-off-by: Tomi Fontanilles <[email protected]>
…lgorithm Signed-off-by: Waleed Elmelegy <[email protected]> Patch from tf-m-tests, applied using: git am ../tf-m-tests/tests_psa_arch/fetch_repo/\ 0011-Add-multiple-expected-return-statuses-in-case-of-inv.patch Signed-off-by: Tomi Fontanilles <[email protected]>
Point to our own guidelines. Signed-off-by: Tomi Fontanilles <[email protected]>
tomi-font
force-pushed
the
rewrite_history_add_patch_guidelines
branch
from
3f99e9a to
1b81a77
Compare
wearyzen
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the history, starting from a clean upstream state, to add commit tags as per the new guidelines.
Also, replace the readme to point to those new guidelines.