dts: only generate getters for okay nodes #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code generated for disabled nodes produces Rust compiler errors, thus we must not generate getters for unavailable nodes. Fixes building for RP2350 (otherwise passes and works). > A node is considered enabled if its status property > is either ``"okay"`` or not defined > For backwards compatibility, the value ``"ok"`` > is treated the same as ``"okay"`` Signed-off-by: Dmitrii Sharshakov <[email protected]>
|
Examples tested on RP2350: async-philosophers, blinky |
|
I tested it with a custom tricore port as well. Fixes the build errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code generated for disabled nodes produces Rust compiler errors, thus
we must not generate getters for unavailable nodes.
Fixes building for RP2350 (otherwise passes and works).
Signed-off-by: Dmitrii Sharshakov [email protected]