Skip to content

Add TI RTI watchdog driver support for am243x-evm #100291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add TI RTI watchdog driver support for am243x-evm #100291

wants to merge 2 commits into from
+65 −1

Conversation

@Sunil-Hegde
Copy link

@Sunil-Hegde Sunil-Hegde commented Dec 1, 2025

  • Adds watchdog support for TI am243x-evm on r5f0_0 core
  • Add callback support in the existing driver

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Hello @Sunil-Hegde, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@Sunil-Hegde Sunil-Hegde force-pushed the watchdog-am243x branch 4 times, most recently from 75db7b9 to edd9468 Compare December 1, 2025 12:04
natto1784
natto1784 suggested changes Dec 1, 2025
View reviewed changes
@zephyrbot zephyrbot added the area: Samples Samples label Dec 2, 2025
@Sunil-Hegde Sunil-Hegde force-pushed the watchdog-am243x branch 2 times, most recently from a288a00 to c9ce26e Compare December 2, 2025 10:18
@zephyrbot zephyrbot added the platform: TI K3 Texas Instruments Keystone 3 Processors label Dec 2, 2025
@kartben kartben assigned glneo and unassigned kartben Dec 2, 2025
@kartben
Copy link
Contributor

kartben commented Dec 2, 2025

assigning K3 maintainer

glneo
glneo reviewed Dec 2, 2025
View reviewed changes
drivers/watchdog/wdt_ti_rti.c

struct wdt_ti_rti_config {
DEVICE_MMIO_ROM;

Copy link
Contributor

@glneo glneo Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave these newlines as-is, same below.

Copy link
Author

@Sunil-Hegde Sunil-Hegde Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Contributor

@natto1784 natto1784 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can still see newline deletions at other places for no reason.

Copy link
Author

@Sunil-Hegde Sunil-Hegde Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry i thought that was only for rti_data and rti_config
i will fix everything

glneo
glneo reviewed Dec 2, 2025
View reviewed changes
drivers/watchdog/wdt_ti_rti.c Outdated
}

/* Clear the Watchdog status register before enabling */
regs->WDSTATUS = 0x3f;
Copy link
Contributor

@glneo glneo Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x3f is a magic number here.

Copy link
Author

@Sunil-Hegde Sunil-Hegde Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to a macro

glneo
glneo reviewed Dec 2, 2025
View reviewed changes
drivers/watchdog/wdt_ti_rti.c Outdated
uint32_t timer_margin;
int window_size;

if (cfg->callback != NULL) {
Copy link
Contributor

@glneo glneo Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to check here, assigning NULL to a var that is already NULL doesn't hurt. And if it wasn't NULL before, then maybe it should be after this call. Just check for NULL before you call it (which is already done below).

Copy link
Author

@Sunil-Hegde Sunil-Hegde Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@natto1784
Copy link
Contributor

natto1784 commented Dec 2, 2025

Fix the compliance issues, make sure to run checkpatch.pl pre commit

board: ti: am243x: Add watchdog support
5260c2a 
- Use main_rti8 as watchdog timer for r5f0_0 core

Signed-off-by: Sunil Hegde <[email protected]>
drivers: watchdog: wdt_ti_rti.c: add callback support
124dfab 
- Add callback support for the wathdog driver.

Signed-off-by: Sunil Hegde <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glneo glneo glneo left review comments

@katsuster katsuster Awaiting requested review from katsuster

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@JarmouniA JarmouniA Awaiting requested review from JarmouniA

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

@dnltz dnltz Awaiting requested review from dnltz

@gramsay0 gramsay0 Awaiting requested review from gramsay0

@vaishnavachath vaishnavachath Awaiting requested review from vaishnavachath

+1 more reviewer

@natto1784 natto1784 natto1784 requested changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@glneo glneo

Labels

area: Boards/SoCs area: Samples Samples area: Watchdog Watchdog platform: TI K3 Texas Instruments Keystone 3 Processors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sunil-Hegde @kartben @natto1784 @glneo @zephyrbot