Skip to content

Conversation

@aarondelago
Copy link
Contributor

This commit fixes two typos in the /zephyr/include/zephyr/storage/disk_access.h header file.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Hello @aarondelago, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message, "This commit fixes two typos in the /zephyr/include/zephyr/storage/disk_access.h header file." is too long. There is no reason to mention /zephyr/include/zephyr/storage/disk_access in the commit message at all.

The commit title and message should be

include: storage: fixes typo in disk_access.h

Fix two typos in the disk access header file.

Signed-off-by: Aaron Delago <[email protected]>

Please fix commit message and title.

Fix two typos in the disk access header file.

Signed-off-by: Aaron Delago <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

@kartben kartben self-assigned this Dec 2, 2025
@kartben kartben added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Dec 2, 2025
@kartben
Copy link
Contributor

kartben commented Dec 2, 2025

adding myself as assignee for this documentation change - thanks @aarondelago!

@kartben kartben requested a review from jfischer-no December 3, 2025 10:51
Copy link
Contributor

@jfischer-no jfischer-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nashif nashif merged commit bc6edd9 into zephyrproject-rtos:main Dec 3, 2025
30 checks passed
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Hi @aarondelago!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Disk Access area: Documentation area: Storage Storage subsystem Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants