drivers: bluetooth: hci: add support for bt_disable() function call #86645

nirav-agrawal · 2025-03-05T08:06:07Z

Added flag in nxp setup driver to perform HCI controller firmware- load and configuration only once. This avoids loading/setting-up controller firmware on successive h4_open() after h4_close().
Added HCI command to send HCI_RESET in bt_disable() function and remove its call from hci-driver close() call.
Remove rsp buf pass to hci_reset_complete() function as status is already checked under 'bt_hci_cmd_send_sync()' func.

For HCI H4 driver, close() call is added in this PR: #86424.
one more PR to be merged before current PR, https://github.com/zephyrproject-rtos/zephyr/pull/86462/files

drivers/bluetooth/hci/h4.c

cvinayak

Does this duplicate or supercede #86424 ?

cvinayak · 2025-03-05T11:09:52Z

subsys/bluetooth/host/hci_core.c

+		struct net_buf *rsp;
+		err = bt_hci_cmd_send_sync(BT_HCI_OP_RESET, NULL, &rsp);
+		if (err) {
+			LOG_ERR("Failed to reset BLE controller");
+			return err;
+		}
+		hci_reset_complete(rsp);
+		net_buf_unref(rsp);


Suggested change

struct net_buf *rsp;

err = bt_hci_cmd_send_sync(BT_HCI_OP_RESET, NULL, &rsp);

if (err) {

LOG_ERR("Failed to reset BLE controller");

return err;

}

hci_reset_complete(rsp);

net_buf_unref(rsp);

struct net_buf *rsp;

err = bt_hci_cmd_send_sync(BT_HCI_OP_RESET, NULL, &rsp);

if (err) {

LOG_ERR("Failed to reset BLE controller");

return err;

}

hci_reset_complete(rsp);

net_buf_unref(rsp);

Hi @cvinayak, I did not notice that the PR is already raised for this requirement. I have checked the PR you mentioned. It has some partial change and might need some more work for other HCI driver to work with bt init & bt disable flow.

I have updated my current PR and removed changes made for H4 driver which is already done under #86424 PR. Rest all other changes are required to work bt_disable() correctly. Thank you.

Hi @cvinayak , suggestion amended. thank you.

drivers/bluetooth/hci/hci_nxp.c

subsys/bluetooth/host/hci_core.c

nirav-agrawal · 2025-03-06T07:41:12Z

drivers/bluetooth/hci/hci_nxp.c

+
+	ret = PLATFORM_TerminateBle();
+	if (ret < 0) {
+		LOG_ERR("Failed to shutdown BLE controller");


Hi @zhaynxp, the only change I did was to remove hci- reset calls. In this code, the above code was called as per return status of hci-reset command, so I updated code to remove that dependency.
I understand your point; I will wait for your PR to be merged and will rebase my PR to keep your change. It will be look like below code,

static int bt_nxp_close(const struct device *dev) { struct bt_nxp_data *hci = dev->data; hci->recv = NULL; return 0; }

please suggest. thank you.

regards,
Nirav

axelnxp

ok with the change, just remember this will conflict with #86462 and will need sequencing

- added HCI command to send hci-reset in bt_disable() func, and remove its call from the driver close() call. - remove rsp buf pass to 'hci_reset_complete()' func as status is already checked under 'bt_hci_cmd_send_sync()'. Signed-off-by: Nirav Agrawal <[email protected]>

nirav-agrawal · 2025-03-10T07:53:19Z

HI @axelnxp, @jhedberg,
I rebased this PR with latest main where dependent PR is already merged. Pls approve this PR to get merged. Thank you.

jhedberg · 2025-03-10T08:08:41Z

drivers/bluetooth/hci/h4.c

-			LOG_DBG("Calling bt_recv(%p)", buf);
-			h4->recv(dev, buf);
+			if (h4->recv != NULL) {
+				LOG_DBG("Calling bt_recv(%p)", buf);
+				h4->recv(dev, buf);
+			}


h4_close() calls k_thread_abort(cfg->rx_thread); before setting h4->recv = NULL;. I'm not sure how thread aborting works in practice, but I'd assume that the right thing to do here in case recv is NULL is to just return from the function, right?

Also, this change to h4.c seems independent of any NXP-related changes, so I'd keep it in its own commit (in fact, it seems like a bug fix to the h4_close() PR that was already merged).

Hi @jhedberg, Yes your point is valid. if we abort the thread then no need to put such condition. I will revert those change and update this PR. thank you

Hi @jhedberg, the changes in h4.c is reverted. please check. thank you.

- added flag in nxp setup driver to perform HCI controller firmware- load and configuration only once. This avoid loading/setting-up controller fw on successive bt_init() after bt_disable() call. Signed-off-by: Nirav Agrawal <[email protected]>

zephyrbot added area: Bluetooth HCI Bluetooth HCI Driver area: Bluetooth platform: NXP Drivers NXP Semiconductors, drivers labels Mar 5, 2025

zephyrbot requested review from alwa-nordic, cvinayak, dleach02, hermabe, HoZHel, jhedberg, MaochenWang1, sjanc, Thalley and theob-pro March 5, 2025 08:06

zephyrbot assigned jhedberg and alwa-nordic Mar 5, 2025

nirav-agrawal force-pushed the add_hci_close_support_in_h4_driver branch 2 times, most recently from 1a3a575 to 3ac826f Compare March 5, 2025 08:26

jhedberg requested changes Mar 5, 2025

View reviewed changes

drivers/bluetooth/hci/h4.c Outdated Show resolved Hide resolved

nirav-agrawal force-pushed the add_hci_close_support_in_h4_driver branch from 3ac826f to c221ccf Compare March 5, 2025 10:50

zephyrbot added the area: Bluetooth Host Bluetooth Host (excluding BR/EDR) label Mar 5, 2025

zephyrbot requested a review from rugeGerritsen March 5, 2025 10:50

cvinayak requested changes Mar 5, 2025

View reviewed changes

axelnxp suggested changes Mar 5, 2025

View reviewed changes

drivers/bluetooth/hci/hci_nxp.c Show resolved Hide resolved

nirav-agrawal force-pushed the add_hci_close_support_in_h4_driver branch from c221ccf to 4ff3eb4 Compare March 5, 2025 11:49

nirav-agrawal requested review from axelnxp, jhedberg and cvinayak March 5, 2025 12:08

jhedberg reviewed Mar 5, 2025

View reviewed changes

subsys/bluetooth/host/hci_core.c Outdated Show resolved Hide resolved

nirav-agrawal force-pushed the add_hci_close_support_in_h4_driver branch from 4ff3eb4 to 7652d9c Compare March 5, 2025 13:46

nirav-agrawal changed the title ~~drivers: bluetooth: hci: added h4_close() support~~ drivers: bluetooth: hci: add support for bt_disable() function call Mar 5, 2025

nirav-agrawal requested a review from jhedberg March 5, 2025 14:01

nirav-agrawal force-pushed the add_hci_close_support_in_h4_driver branch 3 times, most recently from 4feb752 to 028f284 Compare March 5, 2025 17:34

zhaynxp reviewed Mar 6, 2025

View reviewed changes

axelnxp approved these changes Mar 6, 2025

View reviewed changes

nirav-agrawal force-pushed the add_hci_close_support_in_h4_driver branch from 028f284 to 4952520 Compare March 10, 2025 07:49

jhedberg reviewed Mar 10, 2025

View reviewed changes

nirav-agrawal force-pushed the add_hci_close_support_in_h4_driver branch from 4952520 to 4608b11 Compare March 10, 2025 08:35

nirav-agrawal requested a review from jhedberg March 10, 2025 08:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: bluetooth: hci: add support for bt_disable() function call #86645

drivers: bluetooth: hci: add support for bt_disable() function call #86645

nirav-agrawal commented Mar 5, 2025 •

edited

Loading

cvinayak left a comment

cvinayak Mar 5, 2025

nirav-agrawal Mar 5, 2025 •

edited

Loading

nirav-agrawal Mar 5, 2025

This comment was marked as resolved.

nirav-agrawal Mar 6, 2025 •

edited by jhedberg

Loading

This comment was marked as resolved.

axelnxp left a comment

nirav-agrawal commented Mar 10, 2025

jhedberg Mar 10, 2025

jhedberg Mar 10, 2025

nirav-agrawal Mar 10, 2025

nirav-agrawal Mar 10, 2025

drivers: bluetooth: hci: add support for bt_disable() function call #86645

Are you sure you want to change the base?

drivers: bluetooth: hci: add support for bt_disable() function call #86645

Conversation

nirav-agrawal commented Mar 5, 2025 • edited Loading

cvinayak left a comment

Choose a reason for hiding this comment

cvinayak Mar 5, 2025

Choose a reason for hiding this comment

nirav-agrawal Mar 5, 2025 • edited Loading

Choose a reason for hiding this comment

nirav-agrawal Mar 5, 2025

Choose a reason for hiding this comment

This comment was marked as resolved.

nirav-agrawal Mar 6, 2025 • edited by jhedberg Loading

Choose a reason for hiding this comment

This comment was marked as resolved.

axelnxp left a comment

Choose a reason for hiding this comment

nirav-agrawal commented Mar 10, 2025

jhedberg Mar 10, 2025

Choose a reason for hiding this comment

jhedberg Mar 10, 2025

Choose a reason for hiding this comment

nirav-agrawal Mar 10, 2025

Choose a reason for hiding this comment

nirav-agrawal Mar 10, 2025

Choose a reason for hiding this comment

nirav-agrawal commented Mar 5, 2025 •

edited

Loading

nirav-agrawal Mar 5, 2025 •

edited

Loading

nirav-agrawal Mar 6, 2025 •

edited by jhedberg

Loading