[DNM] c++: showcase gen_defines.py macro expansion issue #86770
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case is meant to test the use of preprocessor macros that
paste together a number from devicetree with a suffix, like UINT32_C.
The test case is expected to fail because the C++ preprocessor does not
elide comments added by gen_dts_defines.py before expanding the macros,
resulting in errors like the following:
error: pasting "/* 0x2 */" and "U" does not give
a valid preprocessing token
or, in this synthetic test case:
error: unable to find numeric literal operator 'operator""UU'
when accessing values from the devicetree_generated.h header file.
Signed-off-by: Luca Burelli <[email protected]>
|
Closing after additional investigation as I have identified the actual cause - a nested macro expansion fixed by arduino/ArduinoCore-zephyr@1eade10 . Nothing related to C++. 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR showcases the issue fixed by #86758; it is the first commit of that series.