tests: Bluetooth: Split CAP and GMAP AC tests into separate scripts #89352
+3,864
−1,817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 507 out of 527 changed files in this pull request and generated no comments.
Files not reviewed (20)
- tests/bsim/bluetooth/audio/test_scripts/_gmap.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_ac_common.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_1.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_10.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_11.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_12.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_13.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_14.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_2.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_3.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_4.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_5.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_6.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_7.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_8.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_9.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_gmap_ac.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_gmap_ac_1.sh: Language not supported
- tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_gmap_ac_11_i.sh: Language not supported
Thalley
force-pushed
the
cap_gmap_ac_split
branch
2 times, most recently
from
947ea59 to
ae706fb
Compare
Thalley
requested review from
larsgk,
jhedberg,
MariuszSkamra,
sjanc,
fredrikdanebjer,
aescolar,
asbjornsabo,
Casper-Bonde-Bose,
pin-zephyr,
niym-ot,
jthm-ot and
babrsn
aescolar
requested changes
May 1, 2025
tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_ac_common.sh
Outdated
Show resolved
Hide resolved
tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_ac_common.sh
Outdated
Show resolved
Hide resolved
tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/cap_ac_10_16_1_1.sh
Outdated
Show resolved
Hide resolved
tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_gmap_ac_8_ii.sh
Outdated
Show resolved
Hide resolved
tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/cap_ac_10_16_2_1.sh
Outdated
Show resolved
Hide resolved
tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/cap_ac_10_16_2_1.sh
Outdated
Show resolved
Hide resolved
Always have been :D But yeah, there's a lot of tests, and this is just a subset of the tests I want to run, because ideally we'd run all combinations, but I also know that it would be entirely too many. |
aescolar
reviewed
May 1, 2025
tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac_1.sh
Outdated
Show resolved
Hide resolved
Thalley
force-pushed
the
cap_gmap_ac_split
branch
2 times, most recently
from
dc04cc2 to
4169b64
Compare
|
@aescolar updated to used variables instead of function arguments. Added a few more missing tests that I forgot the first time around. |
aescolar
reviewed
May 1, 2025
tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_cap_ac.sh
Outdated
Show resolved
Hide resolved
aescolar
reviewed
May 1, 2025
tests/bsim/bluetooth/audio/test_scripts/audio_config_tests/_gmap_ac.sh
Outdated
Show resolved
Hide resolved
This commit splits the CAP and GMAP audio configuration (AC) tests into separate scripts. The purpose of this is to reduce the runtime of the individual scripts (some, like the cap_ac_11, tests takes a long time to run all combinations). This split also improves support for running them in parallel. An additional, positive, side effect of this is that the logs will also be smaller per run. The new scripts can be run directly, or via the e.g. _cap_ac_X.sh scripts that run entire audio configuration for all presets. The design of how the parameters are passed around, are based on variable instead of function arguments. Effectively they can be used for the same thing, but variables have the advantage that it is easier to deal with longer names, and that any of the test scripts can be called with additional arguments that can, when using variables, easily be forwarded to the call to Execute for the PHY in the _ac_common.sh. Signed-off-by: Emil Gydesen <[email protected]>
aescolar
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits the CAP and GMAP audio configuration (AC) tests into separate scripts. The purpose of this is to reduce the runtime of the individual scripts (some, like the cap_ac_11, tests takes a long time to run all combinations).
This split also improves support for running them in parallel.
An additional, positive, side effect of this is that the logs will also be smaller per run.