boards: quail: MikroBUS #89364
boards: quail: MikroBUS #89364
Conversation
|
Hello @Ole2mail, and thank you very much for your first pull request to the Zephyr project! |
|
@Ole2mail thanks for your contribution. Note that anonymous contributions are not allowed, you need to sign off your commits with your real name. Thanks! |
|
@Ole2mail thanks for signing the commit. You still have some CI issues though, please take a look. |
looking into this now |
Ole2mail
force-pushed
the
main
branch
3 times, most recently
from
6995141 to
13a5c04
Compare
seems like CI is not starting automatically, which makes uncertain what else is missing to fix for the CR/MR/PR. |
|
don't see any fixable error on CI test. seems like the one has been "cancelled". what next to do? |
Ole2mail
force-pushed
the
main
branch
2 times, most recently
from
6dfe3c4 to
f0b27a6
Compare
boards: mikroe: Add quail board Signed-off-by: Oleg Kokorin <[email protected]>
| config SYS_CLOCK_HW_CYCLES_PER_SEC | ||
| default $(dt_node_int_prop_int,/soc/rcc@40023800,clock-frequency) |
There was a problem hiding this comment.
this value is OK but should be in a SoC Kconfig file (unless the board has a different clock source overriding it), @erwango can this be applied at soc level?
There was a problem hiding this comment.
would like to propose to you to make this change as a separate CR/MR/PR, as it will definitely impact the whole stm32f4 family of the boards
this introduces the four mikroBUS™ sockets hub
https://www.mikroe.com/quail