drivers: icm42688: pin9 function #89366
Open
+207
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymleung314
force-pushed
the
icm42688_pin9_function
branch
2 times, most recently
from
baec782 to
5500cb8
Compare
github-actions
bot
requested review from
afontaine-invn,
asemjonovs,
avisconti,
gjabouley-invn,
jeppenodgaard,
MaureenHelm,
rbuisson-invn,
sriccardi-invn,
teburd,
tristan-google,
ubieda and
yperess
ymleung314
force-pushed
the
icm42688_pin9_function
branch
from
5500cb8 to
82f4e9b
Compare
PIN9 of an ICM42688 can be configured as an interrupt output, external clock input or frame sync output. Pin function can now be set via a sensor attribute. Signed-off-by: Yau-ming Leung <[email protected]>
ymleung314
force-pushed
the
icm42688_pin9_function
branch
from
82f4e9b to
cbad13b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIN9 of an ICM42688 can be configured as an interrupt output, external clock input or frame sync output. Pin function can now be set via a sensor attribute.
According to the datasheet, FIFO packet timestamps are scaled with respect to the external clock frequency. I have added a field to the decoder buffer header. It may break existing codebase where the mempool is not large enough for the new header struct.