Skip to content

drivers: serial: Fix litex driver #89379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VynDragon
Copy link
Collaborator

@VynDragon VynDragon commented May 1, 2025

This fixes several ways to hang the driver in many situations, such as a shell, such as:

  • typing too fast
  • going over the read buffer capacity
  • pasting anything
    etc

@github-actions github-actions bot added area: UART Universal Asynchronous Receiver-Transmitter platform: LiteX labels May 1, 2025
@VynDragon VynDragon force-pushed the fix_litex_uart branch 2 times, most recently from d766fb0 to da8b113 Compare May 1, 2025 20:36
@VynDragon
Copy link
Collaborator Author

Is CI dense today? Not only did it get stuck, but now it also reports inexistant issues?

@maass-hamburg
Copy link
Collaborator

Please notice you have to use ur legal name for sign off and as author name.

@VynDragon
Copy link
Collaborator Author

VynDragon commented May 1, 2025

Please notice you have to use ur legal name for sign off and as author name.

not only is it present, but it failed on it alone too.

@VynDragon
Copy link
Collaborator Author

rebased on latest main to see if that changes anything.

@maass-hamburg
Copy link
Collaborator

If you look at the patch view https://patch-diff.githubusercontent.com/raw/zephyrproject-rtos/zephyr/pull/89379.patch

you can see, that the author's name does not match the signed off entry

From 0c8c159c15a2bd4aa60c7a6c1e2acaf479427a2b Mon Sep 17 00:00:00 2001
From: Vdragon <[email protected]>
Date: Thu, 1 May 2025 21:59:00 +0200
Subject: [PATCH] drivers: serial: Fix litex driver

This fixes several ways to hang the driver, such as:
- typing too fast
- going over the read buffer capacity
- pasting anything
- using arrow keys (sending 2 chars at once)
etc

Signed-off-by: Camille BAUD <[email protected]>
---

@VynDragon
Copy link
Collaborator Author

VynDragon commented May 1, 2025

Thanks, but why is it reporting failing on the email instead of the name?

This fixes several ways to hang the driver, such as:
- typing too fast
- going over the read buffer capacity
- pasting anything
- using arrow keys (sending 2 chars at once)
etc

Signed-off-by: Camille BAUD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UART Universal Asynchronous Receiver-Transmitter platform: LiteX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants