sys: clock: add sys_clock api and remove posix from iso c time #90096
+418
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
remove-posix-from-time-equation
branch
2 times, most recently
from
a403e85 to
83dc940
Compare
cfriedt
changed the title
cfriedt
changed the title
cfriedt
force-pushed
the
remove-posix-from-time-equation
branch
13 times, most recently
from
db7b057 to
fe430cf
Compare
I'd like to get those in better shape before marking this ready for review. |
cfriedt
force-pushed
the
remove-posix-from-time-equation
branch
from
fe430cf to
9a4203b
Compare
cfriedt
force-pushed
the
remove-posix-from-time-equation
branch
2 times, most recently
from
5078a47 to
730558c
Compare
|
Question ... would the proposed k_clock APIs be better served somewhere under /subsys as something like sys_clock APIs? I am wary of them being placed under /kernel. |
It might be possible to reuse existing APIs for calculating some of those things though. |
cfriedt
force-pushed
the
remove-posix-from-time-equation
branch
2 times, most recently
from
793d367 to
19947db
Compare
cfriedt
changed the title
cfriedt
force-pushed
the
remove-posix-from-time-equation
branch
3 times, most recently
from
370277c to
c5bbd4f
Compare
cfriedt
force-pushed
the
remove-posix-from-time-equation
branch
5 times, most recently
from
65e5988 to
f42ce7d
Compare
cfriedt
added
Release Notes
| @@ -60,13 +60,14 @@ struct itimerspec { | |||
| #include <errno.h> | |||
There was a problem hiding this comment.
Commit message refers to k_clock instead of sys_clock
The C standard does not guarantee that `thrd_success` is equal to zero, so ensure that the test takes that into account. Signed-off-by: Chris Friedt <[email protected]>
The specification does not say that the first struct timespec passed to thrd_sleep() may be NULL. Preserving the testpoint so that a possible future testsuite can be run that expects faults to occur when undefined behaviour is used. Faults are one possible solution to handling undefined behaviour, but it would be good to come to a concensus about how that should be handled in Zephyr for standard function calls belonging to ISO C or POSIX. Signed-off-by: Chris Friedt <[email protected]>
Use `timespec_from_timeout(K_MSEC(msec), &ts)` instead of leaning on lazily-crafted timespecs with invalid tv_nsec fields. Signed-off-by: Chris Friedt <[email protected]>
Additional entries for the sys_clock API, comprised of: * sys_clock_gettime() * sys_clock_settime() * sys_clock_nanosleep() along with the constants * SYS_CLOCK_REALTIME * SYS_CLOCK_MONOTONIC * SYS_TIMER_ABSTIME The primary motivation for this API is so that libc and other libraries have a familiar-enough API to reach to when POSIX is not available, since POSIX is optional in Zephyr. By adding this API to lib/os, we also eliminate dependency cycles between libc and posix, as lib/os is a mutual dependency. Signed-off-by: Chris Friedt <[email protected]>
Add bullets to release notes for sys_clock_gettime(), sys_clock_settime(), and sys_clock_nanosleep(). These changes were significant, as they make timekeeping dependencies more independent between libc and posix, and remove several unnecessary dependencies on posix for ISO C library routines. Signed-off-by: Chris Friedt <[email protected]>
Remove POSIX clock_gettime() from the common libc time implementation, since POSIX should not be a dependency for ISO C. Instead, use the newly added lib/os sys_clock API. Specifically, sys_clock_gettime(). Signed-off-by: Chris Friedt <[email protected]>
Use the implementation of time() from the common libc, since there it no longer pulls in POSIX. Use is implied for minimal, newlib, and picolibc, and selected for IAR. Signed-off-by: Chris Friedt <[email protected]>
Reduce the dependency on POSIX by taking advantage of the newly added sys_clock_nanosleep(). Signed-off-by: Chris Friedt <[email protected]>
Presumably the time testsuite was separate from the c library set of testsuites because it had a depedency on POSIX. Since that dependency no longer exists, colocate the time testsuite with the other c library testsuites. Signed-off-by: Chris Friedt <[email protected]>
Use the newly added k_clock API in lib/os for * clock_gettime() * clock_settime() * clock_nanosleep() and nanosleep() * gettimeofday() Signed-off-by: Chris Friedt <[email protected]>
The ISO C function time() should not depend on POSIX and this was corrected recently via the common libc time() implementation. Remove this dependency from the network subsystem where it has been unduly needed for some time. Similarly, XSI_SINGLE_PROCESS was a dependency for time() via picolibc, because the time() implementation in picolibc relies on the POSIX gettimeofday() call. However, since Zephyr's common libc time() implementation no longer depends on that, it can be removed as a dependency in the network subsystem as well. Signed-off-by: Chris Friedt <[email protected]>
Remove POSIX_TIMERS and XSI_SINGLE_PROCESS dependencies from the aws cloud sample and the lwm2m client sample, as they are no longer required. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
remove-posix-from-time-equation
branch
from
f42ce7d to
d8a0351
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time()implementation for most libcssys_clock_nanosleep()instead ofnanosleep()time()functionPOSIX_TIMERSandXSI_SINGLE_PROCESSShould be merged after #90060, #90349