SDMA: Fix sound issues after a pause/resume operation #90330
+37
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: DMA
github-actions
bot
requested review from
decsny,
dleach02,
manuargue,
mmahadevan108,
Raymond0225 and
teburd
In order to validate DMA operations introduce channel states. This is done to catch situations where some operations are called in an invalid context. e.g starting a channel before configuring it. Signed-off-by: Daniel Baluta <[email protected]>
Each time we configure an SDMA channel we also compute the total allocated DMA buffer length but we assume is initialized with zero. This is true each time a channel is requested. But if there are multiple calls to configure without releasing the channel the buffer length is not correctly computed. So, we need to initialize it with zero each time we reconfigure the dma channel. Signed-off-by: Daniel Baluta <[email protected]>
|
@LaurentiuM1234 @iuliana-prodan please review. |
|
iuliana-prodan
approved these changes
May 23, 2025
| @@ -395,6 +423,12 @@ static int dma_nxp_sdma_reload(const struct device *dev, uint32_t channel, uint3 | |||
| return 0; | |||
| } | |||
|
|
|||
| /* allow reload only for active channels */ | |||
| if (chan_data->state != SDMA_CHAN_STATE_STARTED) { | |||
| LOG_ERR("%s: invalid state %d", __func__, chan_data->state); | |||
There was a problem hiding this comment.
drop the function name prefix. CONFIG_LOG_FUNC_NAME_PREFIX_ should already do the job.
| @@ -347,8 +365,15 @@ static int dma_nxp_sdma_start(const struct device *dev, uint32_t channel) | |||
|
|
|||
| chan_data = &dev_data->chan[channel]; | |||
|
|
|||
| if (chan_data->state != SDMA_CHAN_STATE_STOPPED && | |||
| chan_data->state != SDMA_CHAN_STATE_CONFIGURED) { | |||
| LOG_ERR("%s: invalid state %d", __func__, chan_data->state); | |||
| SDMA_CHAN_STATE_STARTED, | ||
| SDMA_CHAN_STATE_STOPPED, | ||
| SDMA_CHAN_STATE_SUSPENDED, | ||
| SDMA_CHAN_STATE_RELEASING, |
| SDMA_CHAN_STATE_CONFIGURED, | ||
| SDMA_CHAN_STATE_STARTED, | ||
| SDMA_CHAN_STATE_STOPPED, | ||
| SDMA_CHAN_STATE_SUSPENDED, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series introduces sdma channel states in order to prevent invalid state transitions and adds a fix for pause/resume sound issue because computation for total buffer length was wrong.