-
Notifications
You must be signed in to change notification settings - Fork 7.4k
templates: use a new bug template based on forms. #90335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
32e8514
to
e5df87b
Compare
@@ -0,0 +1,83 @@ | |||
name: Bug Report | |||
description: File a bug report. | |||
title: "[Bug]: " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is this a regression? If yes, have you been able to "git bisect" it to a | ||
specific commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be too much to have this as a dropbox? Regressions are very bad it'd be nice to have this bit of information stand out a bit more, mainly hoping to get more people to bisect their bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkbox maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that'll do
- type: checkboxes | ||
id: terms | ||
attributes: | ||
label: Code of Conduct | ||
description: | | ||
By submitting this issue, you agree to follow our | ||
[Code of Conduct](https://github.com/zephyrproject-rtos/zephyr/blob/main/CODE_OF_CONDUCT.md). | ||
options: | ||
- label: I agree to follow this project's Code of Conduct | ||
required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems excessive having to check this for every single bug.
- type: dropdown | ||
attributes: | ||
label: Impact | ||
description: Impact of this bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sad to lose the freetext here, sometimes there's good information in it.
e5df87b
to
dc589eb
Compare
dc589eb
to
b3825d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't Additional context
part of this? Quite useful if you want to add references to specs, other issues, etc.
id: logs | ||
attributes: | ||
label: Relevant log output | ||
description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be rendered in the browser as monospace? If so, then I think the second sentence can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the info there is to not have people adding backticks, the content will be rendered automatically.
- type: textarea | ||
id: env | ||
attributes: | ||
label: Environment | ||
description: please complete the following information | ||
placeholder: | | ||
- OS: (e.g. Linux, MacOS, Windows) | ||
- Toolchain (e.g Zephyr SDK, ...) | ||
- Commit SHA or Version used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be split into 3 separate areas?
OS and Tool chain could perhaps even be checkboxes with "N/A" and "Other, please specific" as options (if supported).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we will end up with way too many fields, lets see how this goes and we can split out additional fields as we go forward and if it makes sense.
Use a form based template instead of freesyle template. This will force bug reporters to follow the template and provide the needed information and will make triage easier and bug reports consistent. Signed-off-by: Anas Nashif <[email protected]>
b3825d2
to
a51a34d
Compare
|
Use a form based template instead of freesyle template. This will force
bug reporters to follow the template and provide the needed information
and will make triage easier and bug reports consistent.
Signed-off-by: Anas Nashif [email protected]
this is how it will look like: