You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The soc_flash_mcux.c driver only invokes the HAL function for a flash read when CONFIG_SOC_LPC55S36 is defined. When using another chip in the series (LPC55S16 in my case) the FLASH_Read() call was not being used. This causes the flash driver to trigger a hard fault if the target flash area is uninitialized.
This change broadens the guard to instead use CONFIG_SOC_SERIES_LPC55XXX. This is one symbolic level up from (and is selected by) SOC_LPC55S36 as well as the other SOCs in that series which uses this driver.
The LPC55XXX SoC series requires the use of a HAL function to read
from uninitialized flash without triggering a hardfault. This
broadens an existing #ifdef clause so that it is triggered for all
chips in the series instead of only the LPC55S36.
Signed-off-by: Wilkins White <[email protected]>
Hello @wilkinsw, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
platform: NXP Drivers
The soc_flash_mcux.c driver only invokes the HAL function for a flash read when CONFIG_SOC_LPC55S36 is defined. When using another chip in the series (LPC55S16 in my case) the FLASH_Read() call was not being used. This causes the flash driver to trigger a hard fault if the target flash area is uninitialized.
This change broadens the guard to instead use CONFIG_SOC_SERIES_LPC55XXX. This is one symbolic level up from (and is selected by) SOC_LPC55S36 as well as the other SOCs in that series which uses this driver.
The Kconfig for the symbol is here:
https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/nxp/lpc/lpc55xxx/Kconfig.soc#L4