tests: Bluetooth: Tester: Audio: Adds BRS #99788
Conversation
zephyrbot
added
area: Bluetooth Audio
area: Bluetooth Qualification
zephyrbot
added
area: Tests
zephyrbot
requested review from
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
nashif,
niym-ot and
sjanc
|
AutoPTS related PR: auto-pts/auto-pts#1627 |
There was a problem hiding this comment.
Pull request overview
This PR adds API support to the Bluetooth tester for exposing Broadcast Receive State (BRS) and fixes a bug in the core subsystem where encrypt_state was not being set when adding a broadcast source.
- Adds new
btp_bap_broadcast_add_receive_statefunction to create broadcast receive states directly - Registers the new command handler with opcode
BTP_BAP_ADD_BROADCAST_RECEIVE_STATE - Fixes missing
encrypt_stateassignment inbt_bap_scan_delegator_add_src
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/bluetooth/tester/src/audio/btp_bap_broadcast.h | Declares the new btp_bap_broadcast_add_receive_state function |
| tests/bluetooth/tester/src/audio/btp_bap_broadcast.c | Implements the function to parse command parameters, convert BIS sync bitfields, and add a broadcast source to the scan delegator |
| tests/bluetooth/tester/src/audio/btp_bap.c | Registers the new handler for the BTP_BAP_ADD_BROADCAST_RECEIVE_STATE opcode |
| tests/bluetooth/tester/src/audio/btp/btp_bap.h | Defines the protocol structures for the add broadcast receive state command and response |
| subsys/bluetooth/audio/bap_scan_delegator.c | Fixes bug where encrypt_state parameter was not being assigned to the state when adding a source |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes a bug where encrypt state value was not updated based on given parameters. Signed-off-by: Omkar Kulkarni <[email protected]>
omkar3141
force-pushed
the
omku/fix_bass_sr_cp_bv_21_c
branch
from
5e18a61 to
34151b6
Compare
omkar3141
force-pushed
the
omku/fix_bass_sr_cp_bv_21_c
branch
2 times, most recently
from
2e8afaf to
172dd55
Compare
omkar3141
force-pushed
the
omku/fix_bass_sr_cp_bv_21_c
branch
from
82df800 to
1d02d18
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
omkar3141
force-pushed
the
omku/fix_bass_sr_cp_bv_21_c
branch
2 times, most recently
from
b6d8ba8 to
3e0c7bd
Compare
Thalley
left a comment
Thalley
left a comment
There was a problem hiding this comment.
Minor nitpick comments, but aren't blockers
omkar3141
force-pushed
the
omku/fix_bass_sr_cp_bv_21_c
branch
2 times, most recently
from
9bdcbaf to
a143939
Compare
This commit adds API to tester to allow exposing of Broadcast Receive State. Signed-off-by: Omkar Kulkarni <[email protected]>
omkar3141
force-pushed
the
omku/fix_bass_sr_cp_bv_21_c
branch
from
a143939 to
43ec9e4
Compare
|
|
@larsgk, we would very much appreciate your eye on this one, as we are in a bit of a hurry to get it merged. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7 participants
This commit adds API to tester to allow exposing of Broadcast Receive State.