Fix Mach port leak in alt_clock_gettime for macOS#4839
Closed
qingweizhang054 wants to merge 1 commit intozeromq:masterfrom
Closed
Fix Mach port leak in alt_clock_gettime for macOS#4839qingweizhang054 wants to merge 1 commit intozeromq:masterfrom
qingweizhang054 wants to merge 1 commit intozeromq:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix Mach port leak in alt_clock_gettime for macOS
Description:
While reviewing the clock implementation for macOS (legacy versions < 10.12), I noticed a Mach port leak in
alt_clock_gettime.According to Mach kernel documentation,
mach_host_self()returns a send right to the host's port which increments the port's reference count. This right must be released usingmach_port_deallocateto prevent resource exhaustion in long-running processes.Changes:
mach_host_self()in a local variable.mach_port_deallocatefor the host port after obtaining the clock service.Impact:
clock_gettime.