-
-
Notifications
You must be signed in to change notification settings - Fork 64
Update sphinx requirement from <8 to <9 #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/pip/sphinx-lt-9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can't be merged, there are some problems in the nbpshinx + sphinx changes that crashes. The problem relates to the fact that the sphinx API changes # Platform: linux; (Linux-6.1.0-26-amd64-x86_64-with-glibc2.36)
# Sphinx version: 8.1.3
# Python version: 3.11.7 (CPython)
# Docutils version: 0.21.2
# Jinja2 version: 3.1.4
# Pygments version: 2.18.0
# Last messages:
# quickstart/index
#
#
# reading sources... [ 89%]
# quickstart/install
#
#
# reading sources... [ 90%]
# quickstart/intro_tutorials/01_geometry
#
# Loaded extensions:
# sphinx.ext.mathjax (8.1.3)
# alabaster (1.0.0)
# sphinxcontrib.applehelp (2.0.0)
# sphinxcontrib.devhelp (2.0.0)
# sphinxcontrib.htmlhelp (2.1.0)
# sphinxcontrib.serializinghtml (2.0.0)
# sphinxcontrib.qthelp (2.0.0)
# sphinx.ext.autodoc.preserve_defaults (8.1.3)
# sphinx.ext.autodoc.type_comment (8.1.3)
# sphinx.ext.autodoc.typehints (8.1.3)
# sphinx.ext.autodoc (8.1.3)
# sphinx.ext.autosummary (8.1.3)
# sphinx.ext.intersphinx (8.1.3)
# sphinx.ext.extlinks (8.1.3)
# sphinx.ext.napoleon (8.1.3)
# sphinx.ext.todo (8.1.3)
# sphinx.ext.viewcode (8.1.3)
# sphinx_togglebutton (0.3.2)
# sphinx_copybutton (0.5.2)
# sphinx_design (0.6.1)
# sphinxcontrib.jquery (4.1)
# sphinx_inline_tabs (2023.04.21)
# matplotlib.sphinxext.plot_directive (3.7.1)
# IPython.sphinxext.ipython_directive (unknown version)
# IPython.sphinxext.ipython_console_highlighting (unknown version)
# sphinx.ext.graphviz (8.1.3)
# sphinx.ext.inheritance_diagram (8.1.3)
# nbsphinx (0.9.5)
# sphinx_gallery.load_style (0.18.0)
# sphinxcontrib.bibtex (2.6.3)
# sphinx_rtd_theme (unknown version)
# Traceback:
Traceback (most recent call last):
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/sphinx/cmd/build.py", line 514, in build_main
app.build(args.force_all, args.filenames)
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/sphinx/application.py", line 381, in build
self.builder.build_update()
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/sphinx/builders/__init__.py", line 358, in build_update
self.build(
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/sphinx/builders/__init__.py", line 385, in build
updated_docnames = set(self.read())
^^^^^^^^^^^
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/sphinx/builders/__init__.py", line 502, in read
self._read_serial(docnames)
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/sphinx/builders/__init__.py", line 567, in _read_serial
self.read_doc(docname)
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/sphinx/builders/__init__.py", line 630, in read_doc
publisher.publish()
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/docutils/core.py", line 234, in publish
self.document = self.reader.read(self.source, self.parser,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/sphinx/io.py", line 106, in read
self.parse()
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/docutils/readers/__init__.py", line 76, in parse
self.parser.parse(self.input, document)
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/nbsphinx/__init__.py", line 667, in parse
env.config.nbsphinx_prolog).render(env=env)
^^^^^^^^^^^^^^^
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/jinja2/environment.py", line 1304, in render
self.environment.handle_exception()
File "/home/nicpa/codes/sisl/docs/.venv-docs/lib/python3.11/site-packages/jinja2/environment.py", line 939, in handle_exception
raise rewrite_traceback_stack(source=source)
File "<template>", line 2, in top-level template code
TypeError: can only concatenate str (not "_StrPath") to str
|
f31eacb to
042c19d
Compare
|
@dependabot rebase |
Updates the requirements on [sphinx](https://github.com/sphinx-doc/sphinx) to permit the latest version. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES.rst) - [Commits](sphinx-doc/sphinx@v0.1.61611...v8.1.3) --- updated-dependencies: - dependency-name: sphinx dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
042c19d to
221a111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on sphinx to permit the latest version.
Release notes
Sourced from sphinx's releases.
Changelog
Sourced from sphinx's changelog.
... (truncated)
Commits
a1510deBump to 8.1.3 final62e9606Restore support forcut_lines()with no object type (#13015)5ae32ceBump versiona72b47bBump to 8.1.2 final39a45adExposeExtensionErrorinsphinx.utilfor backwards compatibility.5a4859aAdd docs about sphinx-autobuild (#13011)05679efType-check the 'autodoc_intenum' example (#12827)86d1d31Prune CHANGES of unneeded sectionsb6269d3Improve documentation for the Builder API (#13008)c46abc4Improve clarity formaster_docandroot_docYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)