Fix overhang on mobile in 0.14.0 release notes #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congrats on the latest release!
I tried reading the release announcement on a Pixel 7a, and the rendering leaves a lot of whitespace due to one long hash:
I believe these CSS changes should fix the overhang.
I am not able to verify that this fix fixes the issue, as I'm not able to get the release notes to render at all when I run
zig build servelocally. I can get most of the site to serve, but on my dev system, hardcodes the release notes tohttps://ziglang.org/download/0.14.0/release-notes.htmlrather than thehttp://127.0.0.1:1990domain.If I manually replace the domain and construct a URL as
http://127.0.0.1:1990/download/0.14.0/release-notes.html, I get a 404 even though other pages work.