http: Add missing tls setup when using proxy tunnel #23365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4452852
commented
Mar 30, 2025
| @@ -1487,6 +1488,38 @@ pub fn connectTunnel( | |||
| conn.port = tunnel_port; | |||
| conn.closing = false; | |||
|
|
|||
| if (tunnel_protocol == .tls) { | |||
There was a problem hiding this comment.
This block just mimics what we did in connectTcp.
tw4452852
force-pushed
the
push-mkzllxzkyyuk
branch
from
14f5439 to
e78f805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing a https connection through a proxy tunnel, we need to initialize tls at first, but this step is missing right now unfortunately.
I encountered this issue in my local network environment which is behind a proxy, it works now with this change.
Closes #19878