refactor: merge MilvusS3Option into MilvusOption for unified configur… #57
+176
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shaoting-huang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ation
Consolidate S3/FileSystem configuration into MilvusOption to simplify the
codebase and provide a single, unified configuration API.
Changes:
- Merged all S3 configuration fields from MilvusS3Option into MilvusOption
(readerType, s3FileSystemType, s3BucketName, s3RootPath, s3Endpoint,
s3AccessKey, s3SecretKey, s3UseSSL, s3PathStyleAccess, s3MaxConnections,
s3PreloadPoolSize)
- Moved helper methods (notEmpty, getConf, getFileSystem, getFilePath)
from MilvusS3Option to MilvusOption
- Updated MilvusOption.apply() to parse S3 configuration fields
- Removed MilvusS3Option case class and companion object
- Updated all references across the codebase:
* sources/MilvusDataSource.scala
* binlog/MilvusBinlogDataSource.scala
* read/MilvusPartitionReader.scala
* read/MilvusPartitionReaderFactory.scala
* write/MilvusSparkNativeImportWriter.scala
- Fixed reference to milvusPKType -> collectionPKType in binlog reader
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
force-pushed
the
milvusoptions
branch
from
51553f1 to
2e1d004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation
Consolidate S3/FileSystem configuration into MilvusOption to simplify the
codebase and provide a single, unified configuration API.
Changes: