Early exit from a message handler should not skip subsequent handlers #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise an error to notify the developer to use `next` instead of `return` to skip (part of) the message handler code. In Ruby the `return` from a block returns from the enclosing method. Since we capture blocks when registering handlers with `on` and then execute them later using `instance_exec` this causes unintuitive behaviour, as subsequent handlers are no longer executed when a handler uses `return`.
erikrozendaal
force-pushed
the
return-from-handler-should-not-skip-subsequent-handlers
branch
from
0941652 to
b1adeed
Compare
erikrozendaal
changed the title
This way `return` behaves as expected (returning only from the handler, instead of breaking out of the loop calling all handlers).
erikrozendaal
deleted the
return-from-handler-should-not-skip-subsequent-handlers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an error to notify the developer to use
nextinstead ofreturnto skip (part of) the message handler code.Use
define_methodto make event handler blocks behave likenormal Ruby methods, so using
returnjust returns from themessage handler body and does not exit the event handling loop
of the message dispatcher.
In Ruby the
returnfrom a block returns from the enclosingmethod. Since we capture blocks when registering handlers with
onand then execute them later using
instance_execthis causesunintuitive behaviour, as subsequent handlers are no longer executed
when a handler uses
return.