JsonRpsee for Zaino client #246
Merged
+142
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review, I think I caught everything but please give it a thorough look, as this is my first significant contribution to Zaino, and I might not be aware of all the ways it's being used or tested.. I imagine changing the names a bit more, either to all be I have a few follow on questions also. |
AloeareV
approved these changes
Mar 24, 2025
pacu
reviewed
Mar 24, 2025
| } | ||
|
|
||
| /// Converts JsonRpcConnectorError to tonic::Status | ||
| /// Converts JsonRpSeeConnectorError to tonic::Status | ||
| /// | ||
| /// TODO: This impl should be changed to return the correct status [https://github.com/zcash/lightwalletd/issues/497] before release, |
There was a problem hiding this comment.
Add issue so we don't forget about it ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #195