-
Notifications
You must be signed in to change notification settings - Fork 13
new zaino ci docker #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
new zaino ci docker #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It ignores all testnet tests, they require a fully synced testnet wallet and are temporary anyways.
- Had to add a local .cargo/config.toml file to tweak the way my local cargo uses git.
- Used ACT to test workflows locally, let's see how they go live... - The 'restore cache' step isn't tested yet - The bins are copied into 'test_binaries' as well as available in $PATH - The tests are run with nextest - The nextest profile 'ci' is used to avoid running testnet tests - There're some tests failing, mainly the `client_rpc` ones - I suspect that exposing a port for Zaino will fix the last item
- This job was failing with 'runner out of space' message - Let's try skipping the extra compilation step here and see if that does it
- this was making the ci fail in build-test-artifacts job
matrix strategy to not fails when a single partition fails
The "Build docker image, push if tag ..." job fails only cause there's no dockerhub token configured on this repo yet. It's working fine on my fork. |
zancas
reviewed
Mar 27, 2025
zancas
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to be merged after #250
It adds a new docker image that is used for Zaino CI runs.
Known issues: