Skip to content

new zaino ci docker #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 27, 2025
Merged

new zaino ci docker #251

merged 17 commits into from
Mar 27, 2025

Conversation

nachog00
Copy link
Contributor

This PR is to be merged after #250

It adds a new docker image that is used for Zaino CI runs.

Known issues:

  • Cache isn't being fully taken advantage of yet
  • Chain cache relying tests are failing since cached state isn't being initialized (we should cache it too)
  • Tests matrix is stopping all tests execution on first fail

nachog00 added 13 commits March 24, 2025 12:33
It ignores all testnet tests, they require a fully synced testnet wallet and are temporary anyways.
- Had to add a local .cargo/config.toml file to tweak the way my local cargo uses git.
- Used ACT to test workflows locally, let's see how they go live...
- The 'restore cache' step isn't tested yet
- The bins are copied into 'test_binaries' as well as available in $PATH
- The tests are run with nextest
- The nextest profile 'ci' is used to avoid running testnet tests
- There're some tests failing, mainly the `client_rpc` ones
- I suspect that exposing a port for Zaino will fix the last item
- This job was failing with 'runner out of space' message
- Let's try skipping the extra compilation step here and see if that does it
- this was making the ci fail in build-test-artifacts job
@nachog00 nachog00 requested a review from idky137 March 24, 2025 17:15
nachog00 and others added 3 commits March 27, 2025 11:07
@nachog00
Copy link
Contributor Author

This is running most tests now. A subsequent PR will disable the ones we agreed on @idky137 @AloeareV

@nachog00
Copy link
Contributor Author

The "Build docker image, push if tag ..." job fails only cause there's no dockerhub token configured on this repo yet. It's working fine on my fork.

@zancas zancas merged commit 5431cf0 into zingolabs:dev Mar 27, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants