Rename cmake target files to avoid overwrite of PACKAGE_VERSION#912
Rename cmake target files to avoid overwrite of PACKAGE_VERSION#912bebuch wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes CMake export naming conventions by appending -targets suffix to the export name throughout the installation configuration. This ensures consistency with CMake best practices where export files are typically named <package>-targets.cmake rather than <package>.cmake.
Key changes:
- Updated CMake export name from
${MINIZIP_TARGET}to${MINIZIP_TARGET}-targets - Modified corresponding include statement to reference the correct export file name
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
One minute before the zlib-ng PR you link to was merged, another zlib-ng PR was merged with renamings and concerns by @nmoinvaz : zlib-ng/zlib-ng#1970 So we might need to look at both zlib-ng changes to evaluate what's the next move for minizip-ng. |
|
This looks like a completely distinct thing. My PRs only affect the target file names, whereas this other PR only affects the target names. Note that target file names are an implementation detail. The CMake config file API doesn't depend on them, so my change won't break anything. |
|
This will be commit as part of #982. |
Same patch as zlib-ng/zlib-ng#1988 for zlib-ng.