fix(cmake): Correct Zlib-ng static link by separating link and install targets #929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building minizip-ng as a static library (undefined BUILD_SHARED_LIBS) with Zlib-ng, the .vcxproj generated by CMake incorrectly referred to the dynamic library target (
zlib) instead of the static library target (zlibstatic) in its linker settings.This fix separates the targets in CMake:
zlibstaticfor target_link_libraries() to ensure the generated .vcxproj correctly references the static library.zlibfor install(TARGETS...) to prevent CMake alias errors during installation (CI).