add allowNTLMCredentialsForDomains option to enterprise config file#1402
add allowNTLMCredentialsForDomains option to enterprise config file#1402sliezz wants to merge 0 commit intozulip:mainfrom
allowNTLMCredentialsForDomains option to enterprise config file#1402Conversation
|
Heads up @sliezz, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
Are there any reason to spend my time on this? |
|
Generally review attention across the Zulip project is spent on PRs that are well-presented and follow our contributing guidelines. It'd be great if someone had had the time to reply pointing you to that documentation when you first opened your PR. Even "simple" features require care - what is the right name for the setting? How can we document it so that end users can understand the decision for what it does, and know what formats are valid for the domains? Etc. That doesn't mean it can't be picked up and finished by maintainers. We certainly appreciate your submitting the PR! But PRs where there's still a good amount of expert work required to finish them tend to wait a lot longer, especially in this repository. |
This PR add an ability to system administrators of configuring NTLM Credentials for domains without recompiling Zulip Desktop сlient app.
There is an Electron demand to implicity configure a list of servers for which integrated authentication is enabled.
Electon docs
In fact It useful only in an Enterprise environments I think we should configure it in appropriate config file
Fixes:
allowNTLMCredentialsForDomainsto "Zulip-Desktop-Config/global_config.json"Platforms this PR was tested on:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: