Fix: emoji autocomplete, match insensitively to diacritics#1459
Closed
AshutoshKhadse23 wants to merge 1 commit intozulip:mainfrom
Closed
Fix: emoji autocomplete, match insensitively to diacritics#1459AshutoshKhadse23 wants to merge 1 commit intozulip:mainfrom
AshutoshKhadse23 wants to merge 1 commit intozulip:mainfrom
Conversation
Member
|
As you know from other PRs, we're focusing on launch issues until the app is launched; and this is a post-launch issue. So I'm marking it as draft to get it out of our queue. |
AshutoshKhadse23
force-pushed
the
fix-emoji-diacritic
branch
2 times, most recently
from
87def46 to
04e32a8
Compare
AshutoshKhadse23
force-pushed
the
fix-emoji-diacritic
branch
from
04e32a8 to
8679d7f
Compare
Contributor
Author
|
@gnprice, |
Member
|
What leads you to believe that the situation described above in #1459 (comment) has changed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1067
The implementation is simple use well known package code diacritic for cleaner approach.
If you dont want to use package just let me know ?