Add language setting

[AshutoshKhadse23]

Issue #1139

Added the language setting into the appropriate setting button.

issue.1139.mp4

[gnprice]

Hi, thanks for the contribution.

Please see our README for the basic requirements this PR will need to meet before we can review it.

[AshutoshKhadse23]

Did you mean to add test for the language code ?

[gnprice]

What does the README say under "Submitting a pull request"?

[AshutoshKhadse23]

Understood !!

[AshutoshKhadse23]

Added the test which ensure that :

• Users can view and change language settings
• The UI properly reflects the current language
• Navigation works correctly
• The search functionality is present
• Selection state is visually indicated

[gnprice]

Yeah, tests are one thing that's needed. There are two bulleted list items in that section, though — what's the other one say?

This also doesn't appear to actually add any setting. A setting means something the user sets which is then stored, on the device, so that their choice is remembered the next time they run the app. See the issue, and the broader issue it links to which this issue is "an instance of".

[AshutoshKhadse23]

Sorry for that I will add the relevant test case for that and now I had store the language preference.

[PIG208]

Hi @AshutoshKhadse23! Thanks for the PR. Are you still working on this?

[AshutoshKhadse23]

Hello @PIG208 ,
I think this is the final code, but whyis this not able to be understood "This branch cannot be rebased due to conflicts" as the branch is updated and no conflict (think so ).

[PIG208]

What does the README say under "Submitting a pull request"?

Yeah, tests are one thing that's needed. There are two bulleted list items in that section, though — what's the other one say?

Please refer to the other item Greg referred to in his previous comment. That might help with solving this problem.