Skip to content

msglist: Say "Quote message" for the quote-and-reply button, following web #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assets/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@
"@actionSheetOptionShare": {
"description": "Label for share button on action sheet."
},
"actionSheetOptionQuoteAndReply": "Quote and reply",
"@actionSheetOptionQuoteAndReply": {
"description": "Label for Quote and reply button on action sheet."
"actionSheetOptionQuoteMessage": "Quote message",
"@actionSheetOptionQuoteMessage": {
"description": "Label for the 'Quote message' button in the message action sheet."
},
"actionSheetOptionStarMessage": "Star message",
"@actionSheetOptionStarMessage": {
Expand Down
6 changes: 3 additions & 3 deletions lib/generated/l10n/zulip_localizations.dart
Original file line number Diff line number Diff line change
Expand Up @@ -339,11 +339,11 @@ abstract class ZulipLocalizations {
/// **'Share'**
String get actionSheetOptionShare;

/// Label for Quote and reply button on action sheet.
/// Label for the 'Quote message' button in the message action sheet.
///
/// In en, this message translates to:
/// **'Quote and reply'**
String get actionSheetOptionQuoteAndReply;
/// **'Quote message'**
String get actionSheetOptionQuoteMessage;

/// Label for star button on action sheet.
///
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_ar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
String get actionSheetOptionShare => 'Share';

@override
String get actionSheetOptionQuoteAndReply => 'Quote and reply';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Star message';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_de.dart
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
String get actionSheetOptionShare => 'Share';

@override
String get actionSheetOptionQuoteAndReply => 'Quote and reply';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Star message';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_en.dart
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
String get actionSheetOptionShare => 'Share';

@override
String get actionSheetOptionQuoteAndReply => 'Quote and reply';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Star message';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_it.dart
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class ZulipLocalizationsIt extends ZulipLocalizations {
String get actionSheetOptionShare => 'Share';

@override
String get actionSheetOptionQuoteAndReply => 'Quote and reply';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Star message';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_ja.dart
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
String get actionSheetOptionShare => 'Share';

@override
String get actionSheetOptionQuoteAndReply => 'Quote and reply';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Star message';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_nb.dart
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
String get actionSheetOptionShare => 'Share';

@override
String get actionSheetOptionQuoteAndReply => 'Quote and reply';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Star message';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_pl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
String get actionSheetOptionShare => 'Udostępnij';

@override
String get actionSheetOptionQuoteAndReply => 'Odpowiedz cytując';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Oznacz gwiazdką';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_ru.dart
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
String get actionSheetOptionShare => 'Поделиться';

@override
String get actionSheetOptionQuoteAndReply => 'Ответить с цитированием';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Отметить сообщение';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_sk.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
String get actionSheetOptionShare => 'Zdielať';

@override
String get actionSheetOptionQuoteAndReply => 'Citovať a odpovedať';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Ohviezdičkovať správu';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_sl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class ZulipLocalizationsSl extends ZulipLocalizations {
String get actionSheetOptionShare => 'Deli';

@override
String get actionSheetOptionQuoteAndReply => 'Citiraj in odgovori';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Označi sporočilo z zvezdico';
Expand Down
2 changes: 1 addition & 1 deletion lib/generated/l10n/zulip_localizations_uk.dart
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class ZulipLocalizationsUk extends ZulipLocalizations {
String get actionSheetOptionShare => 'Поширити';

@override
String get actionSheetOptionQuoteAndReply => 'Цитата і відповідь';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Вибрати повідомлення';
Expand Down
8 changes: 1 addition & 7 deletions lib/generated/l10n/zulip_localizations_zh.dart
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class ZulipLocalizationsZh extends ZulipLocalizations {
String get actionSheetOptionShare => 'Share';

@override
String get actionSheetOptionQuoteAndReply => 'Quote and reply';
String get actionSheetOptionQuoteMessage => 'Quote message';

@override
String get actionSheetOptionStarMessage => 'Star message';
Expand Down Expand Up @@ -950,9 +950,6 @@ class ZulipLocalizationsZhHansCn extends ZulipLocalizationsZh {
@override
String get actionSheetOptionShare => '分享';

@override
String get actionSheetOptionQuoteAndReply => '引用消息并回复';

@override
String get actionSheetOptionStarMessage => '添加星标消息标记';

Expand Down Expand Up @@ -1730,9 +1727,6 @@ class ZulipLocalizationsZhHantTw extends ZulipLocalizationsZh {
@override
String get actionSheetOptionShare => '分享';

@override
String get actionSheetOptionQuoteAndReply => '引用並回覆';

@override
String get actionSheetOptionStarMessage => '標註為重要訊息';

Expand Down
2 changes: 1 addition & 1 deletion lib/widgets/action_sheet.dart
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,7 @@ class QuoteAndReplyButton extends MessageActionSheetMenuItemButton {

@override
String label(ZulipLocalizations zulipLocalizations) {
return zulipLocalizations.actionSheetOptionQuoteAndReply;
return zulipLocalizations.actionSheetOptionQuoteMessage;
}

@override void onPressed() async {
Expand Down