Manual (non-automatic) completion update #379
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ape
force-pushed
the
pr/manual_completion_update
branch
from
a788909 to
2a2df7b
Compare
Contributor
Author
|
I rewrote the implementation, and now I would be really happy to have it merged. The updated version is force pushed to this pull request for easy merging, and now the old version is visible on Ape/chromium-vim@a788909. With this new version the commit adds a boolean option |
Ape
force-pushed
the
pr/manual_completion_update
branch
from
2a2df7b to
ac6be78
Compare
Ape
added a commit
to Ape/chromium-vim
that referenced
this pull request
Nov 21, 2015
Command completions (e.g. for 'open' commands) were previously automatically updated when command characters are being typed. This commit adds a boolean option 'manualcompletion' that makes the completions update only when Tab key is pressed. Resolves 1995eaton#379.
Ape
force-pushed
the
pr/manual_completion_update
branch
from
ac6be78 to
e77c823
Compare
Contributor
Author
|
I noticed that I have reported this feature as issue #295. This pull request is the exact implementation to that issue. |
Command completions (e.g. for 'open' commands) were previously automatically updated when command characters are being typed. This commit adds a boolean option 'manualcompletion' that makes the completions update only when Tab key is pressed. Resolves 1995eaton#295.
Ape
force-pushed
the
pr/manual_completion_update
branch
from
e77c823 to
58bb327
Compare
Contributor
Author
|
Rebased on the current master and fixed trivial conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command completions (e.g. for 'open' commands) were previously automatically updated when command characters are being typed. I dislike this automatic behavior. With this commit the completion is only updated when TAB key is pressed.
The implementation is quite simple (see the commit diff), but maybe not very elegant since I only spent very little time learning the code base. Also, this should probably be an optional setting.
Does anybody have feedback about the idea or the implementation?