Feature/atr 728 dev graph declaration diagnostic #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e abstract modifier
SENya1990
commented
Oct 26, 2025
|
|
||
| ## Summary | ||
|
|
||
| | Code | Short Description | Type | Code Fix | |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new diagnostic PX1112 that enforces that graphs and graph extensions with generic type parameters must be declared as abstract. This prevents improper instantiation of generic graphs/extensions in the Acumatica Framework and ensures correct inheritance patterns. The implementation includes the analyzer, code fix, comprehensive tests, and documentation.
Key changes:
- Added diagnostic PX1112 to detect non-abstract generic graphs and graph extensions
- Implemented code fix to add
abstractmodifier and removesealedmodifier when needed - Added comprehensive test coverage for various scenarios including partial types
Reviewed Changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| GraphAndGraphExtensionDeclarationAnalyzer.cs | New analyzer that detects generic graphs/extensions missing abstract modifier |
| TypeModifiersFix.cs | Code fix implementation to add abstract and remove sealed modifiers |
| PXGraphAnalyzer.cs | Registered the new declaration analyzer |
| Descriptors.cs | Added PX1112 diagnostic descriptor |
| Resources.resx | Added diagnostic title and code fix message |
| DiagnosticsShortName.resx | Added short name for PX1112 |
| GenericNonAbstractGraphsAndGraphExtensionsTests.cs | Test suite covering diagnostic and code fix scenarios |
| Various test source files | Test input and expected output files |
| PX1112.md | Documentation for the diagnostic |
| Summary.md | Added PX1112 to diagnostics summary table |
Files not reviewed (2)
- src/Acuminator/Acuminator.Analyzers/DiagnosticsShortName.Designer.cs: Language not supported
- src/Acuminator/Acuminator.Analyzers/Resources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...s/StaticAnalysis/DeclarationAnalysisGraphAndDac/GraphAndGraphExtensionDeclarationAnalyzer.cs
Outdated
Show resolved
Hide resolved
SENya1990
commented
Oct 26, 2025
| | [PX1102](diagnostics/PX1102.md) | The additional delegate parameter of the method with the `PXOverride` attribute must have a name conforming Acumatica naming conventions. | Warning | Available | | ||
| | [PX1110](diagnostics/PX1110.md) | The DAC has a DAC field with the `PXDBLocalizableString` attribute. Therefore, this DAC must declare a `NoteID` DAC field. | Error | Available | | ||
| | [PX1111](diagnostics/PX1111.md) | The primary DAC of a processing view must contain the `NoteID` field. | Error | Unavailable | | ||
| | [PX1112](diagnostics/PX1112.md) | Graphs and graph extensions with generic type parameters must be abstract. | Error | Available | |
SENya1990
commented
Oct 26, 2025
| <data name="PX1111TitleFormat" xml:space="preserve"> | ||
| <value>The primary DAC "{0}" of the processing view "{1}" must contain the "NoteID" field</value> | ||
| </data> | ||
| <data name="PX1112Fix" xml:space="preserve"> |
SENya1990
commented
Oct 26, 2025
| <data name="PX1111" xml:space="preserve"> | ||
| <value>MainDacOfProcessingViewMustContainNoteIdField</value> | ||
| </data> | ||
| <data name="PX1112" xml:space="preserve"> |
dropsonic
approved these changes
Oct 27, 2025
Contributor
Author
|
The documentation review will be done in a separate PR |
SENya1990
deleted the
feature/ATR-728-dev-graph-declaration-diagnostic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented diagnostic PX1112 to report generic non-abstract graphs and graph extensions.
Changes Overview