[1.2] Make properties async #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markatk
force-pushed
the
make-properties-async
branch
from
2a00270 to
59a7cbf
Compare
Micky5991
requested changes
Mar 9, 2019
| { | ||
| CheckExistence(); | ||
|
|
||
| return await _plugin.Schedule(() => StructConverter.PointerToStruct<Vector3>(Rage.Checkpoint.Checkpoint_GetDirection(NativePointer))).ConfigureAwait(false); |
There was a problem hiding this comment.
Move PointerToStruct convert out of scheduled lambda
|
|
||
| return Rage.Player.Player_IsJumping(NativePointer); | ||
| } | ||
| return await _plugin.Schedule(() => StringConverter.PointerToString(Rage.Player.Player_GetKickReason(NativePointer))).ConfigureAwait(false); |
There was a problem hiding this comment.
Move PointerToString call outside scheduled method
|
|
||
| return _plugin.VehiclePool[Rage.Vehicle.Vehicle_GetTrailer(NativePointer)]; | ||
| } | ||
| return await _plugin.Schedule(() => _plugin.VehiclePool[Rage.Vehicle.Vehicle_GetTrailer(NativePointer)]).ConfigureAwait(false); |
There was a problem hiding this comment.
Move _plugin.VehiclePool call out of schedule
| /// <exception cref="EntityDeletedException">This entity was deleted before</exception> | ||
| float Scale { get; set; } | ||
| /// <param name="direction">New direction of the marker</param> | ||
| /// <returns></returns> |
Micky5991
approved these changes
Mar 9, 2019
markatk
force-pushed
the
make-properties-async
branch
from
4eba7d3 to
7c77360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all properties which use native RageMP functions to async getter/setters.